Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/update.php

Line 110: Unused local variable $function

CommentFileSizeAuthor
#2 2056415-01-core-update.patch539 bytesjan.stoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jan.stoeckler’s picture

jan.stoeckler
he/his
Primary language German
CreditAttribution: jan.stoeckler commented
Assigned: Unassigned » jan.stoeckler
Issue tags: +Drupal-Camping 2013

I'll take a look.

jan.stoeckler’s picture

jan.stoeckler
he/his
Primary language German
CreditAttribution: jan.stoeckler commented
Assigned: jan.stoeckler » Unassigned
Status: Active » Needs review
Issue tags: -Drupal-Camping 2013
FileSize
2056415-01-core-update.patch539 bytes

Let's see if it works...

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Drupal-Camping 2013

Thanks a lot! Patch looks great.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 1ffcf57 and pushed to 8.x. Thanks!

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Fixed » Needs work 
diff --git a/core/update.php b/core/update.php
old mode 100644
new mode 100755

this shouldnt happen

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Fixed

Handling this over in #2057445: Fix file wrong file perms introduced by 2056415 and 2056417

jan.stoeckler’s picture

jan.stoeckler
he/his
Primary language German
CreditAttribution: jan.stoeckler commented

I'm sorry, I think i figured out what was wrong on my part. I fixed the permission issue in my installation and hope this won't occur again.

Automatically closed -- issue fixed for 2 weeks with no activity.