Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/field/lib/Drupal/field/Plugin/Core/Entity/FieldInstance.php

Line 355: Unused local variable $module_handler
Line 397: Unused local variable $module_handler

CommentFileSizeAuthor
#2 2056827-module-handler-field-instance.patch1.07 KBjan.stoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Active » Closed (duplicate)

#2056825: Remove Unused local variable $module_handler from /core/modules/field/lib/Drupal/field/Plugin/Core/Entity/FieldInstance.php

jan.stoeckler’s picture

jan.stoeckler
he/his
Primary language German
CreditAttribution: jan.stoeckler commented
Status: Closed (duplicate) » Needs review
FileSize
2056827-module-handler-field-instance.patch1.07 KB

Hope this won't break anything.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

So the other one was in fact closed as a duplicate of this one.

Patch looks great, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 299682e and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.