Patch follows ....

Files: 
CommentFileSizeAuthor
#10 Missing-title-attributes-for-6.x-2057409-10.patch1.03 KBJosefFriedrich
PASSED: [[SimpleTest]]: [MySQL] 3,816 pass(es).
[ View ]
#6 Missing-title-attributes-2057409-6.patch991 bytesJosefFriedrich
PASSED: [[SimpleTest]]: [MySQL] 4,913 pass(es).
[ View ]
#1 Missing-title-attributes-2057409-2.patch1.36 KBJosefFriedrich
FAILED: [[SimpleTest]]: [MySQL] 4,886 pass(es), 19 fail(s), and 4 exception(s).
[ View ]

Comments

StatusFileSize
new1.36 KB
FAILED: [[SimpleTest]]: [MySQL] 4,886 pass(es), 19 fail(s), and 4 exception(s).
[ View ]

Status:Active» Needs review

What's the rationale for changing ">>" to "»"?

Status:Needs review» Needs work

The last submitted patch, Missing-title-attributes-2057409-2.patch, failed testing.

Status:Needs work» Needs review

Most drupal pagers uses "»". In my opinion "»" looks nicer.

StatusFileSize
new991 bytes
PASSED: [[SimpleTest]]: [MySQL] 4,913 pass(es).
[ View ]

Patch without changing ">>" to "»"

Regarding the ">>": if you feel strongly about this, please open a feature request and supply a patch (the tests will need to be fixed in such patch as well). Let's keep this issue to strictly fixing the title attributes, which will increase the chance it is committed substantially.

Status:Needs review» Reviewed & tested by the community

I applied this and the title attributes are now being added properly. Thanks for the patch!

Version:7.x-2.x-dev» 6.x-2.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Committed and pushed to 7.x-2.x and 7.x-1.x, thanks. I think this also needs to be fixed in 6.x or was the API different there?

StatusFileSize
new1.03 KB
PASSED: [[SimpleTest]]: [MySQL] 3,816 pass(es).
[ View ]

Status:Patch (to be ported)» Needs review