Exposed filter blocks do not work anymore [#2057831]

I was going to add test coverage over in #2046993: Inject dependencies into ViewsExposedFilterBlock derivative class, but in starting to do so realised that exposed blocks don't actually work at all at the moment. This is not a problem with the deriver but with the actual ViewsExposedBlock block plugin.

Test coverage should be added here instead.

Steps to reproduce:
- Create view, add page display
- Under 'advanced' change 'Exposed form in block' setting to yes
- Save
- Try to place this new exposed block
- Watch things break

Comment	File	Size	Author
#8	2057831-8.patch	15.3 KB	damiankloip
#8
#8	interdiff-2057831-8.txt	595 bytes	damiankloip
#2	2057831-2-tests-only.patch	4.72 KB	damiankloip
#2
#2	2057831-2.patch	15.29 KB	damiankloip
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

damiankloip CreditAttribution: damiankloip commented 5 August 2013 at 09:43

Issue tags:

+Needs tests

Comment #2

damiankloip CreditAttribution: damiankloip commented 5 August 2013 at 11:00

Status:

Active

» Needs review

File	Size
2057831-2.patch	15.29 KB

2057831-2-tests-only.patch	4.72 KB

Comment #3

dawehner

German

CreditAttribution: dawehner commented 5 August 2013 at 11:37

Issue tags:

-Needs tests

I really like to split up the functionality of the two kind of views blocks!

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/ExposedFormTest.phpundefined
@@ -102,11 +104,45 @@ public function testExposedFormRender() {
+   * @param ViewStorageInterface $view
...
+  protected function getExpectedExposedFormId(ViewExecutable $view) {

The signature and documentation seem to disagree.

Comment #4

dawehner

German

CreditAttribution: dawehner commented 5 August 2013 at 11:37

I really like to split up the functionality of the two kind of views blocks!

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/ExposedFormTest.phpundefined
@@ -102,11 +104,45 @@ public function testExposedFormRender() {
+   * @param ViewStorageInterface $view
...
+  protected function getExpectedExposedFormId(ViewExecutable $view) {

The signature and documentation seem to disagree.

Comment #5

5 August 2013 at 12:22

Status:	Needs review	» Needs work
Issue tags:	-VDC

The last submitted patch, 2057831-2.patch, failed testing.

Comment #6

damiankloip CreditAttribution: damiankloip commented 5 August 2013 at 13:44

Status:	Needs work	» Needs review
Issue tags:		+VDC

#2: 2057831-2.patch queued for re-testing.

Comment #7

dawehner

German

CreditAttribution: dawehner commented 5 August 2013 at 15:12

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/ExposedFormTest.php
@@ -102,11 +104,45 @@ public function testExposedFormRender() {
+   * @param ViewStorageInterface $view
...
+  protected function getExpectedExposedFormId(ViewExecutable $view) {

The @param talks about ViewStorageInterface, but the function has ViewExecutable!

Comment #8

damiankloip CreditAttribution: damiankloip commented 5 August 2013 at 16:21

File	Size
interdiff-2057831-8.txt	595 bytes
2057831-8.patch	15.3 KB

Good call, that line just doesn;t match :)

Comment #9

dawehner

German

CreditAttribution: dawehner commented 5 August 2013 at 17:07

Status:

Needs review

» Reviewed & tested by the community

I really like having a new test for that bit.

Comment #10

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 7 August 2013 at 06:58

Priority:

Normal

» Critical

That sounds much worse than a "normal" bug. :)

I'll need some help walking through this patch on IRC or whatever, since after 3 months off I'm not up to speed on the new way blocks are defined and stuff. Else, we can just leave it for Alex/catch/Dries.