The .clearfix from starterkits/extended/sass/partials/base/_root.scss gets an overflow:hidden. This for example mess up with vertical tabs.

Using @include pie-clearfix; instead of @include clearfix; (in _root.scss) fixes this.

CommentFileSizeAuthor
#9 clearfix-mixin-ohm-2059009-8.patch0 bytesInternet
#5 omega-starterkits-clearfix-2059009-5.patch732 bytesosopolar
#1 omega-starterkits-clearfix-2059009-1.patch374 bytesosopolar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
CreditAttribution: osopolar commented
Title: .clearfix without overflow:hidden » .clearfix should be without overflow:hidden
FileSize
omega-starterkits-clearfix-2059009-1.patch374 bytes

Just fixed this in omega/starterkits/extended/sass/partials/base/_root.scss to:

.clearfix {
  @include pie-clearfix;
}

I am new to sass and not sure what to do with the following clearfixes:
omega/sass/modules/system/utilities/_utilities.base.scss

/**
 * Use the clearfix from toolkit.
 */
@import "toolkit/clearfix";
.clearfix {
  @extend %clearfix-micro;
}

and omega/ohm/sass/partials/base/_root.scss:

.clearfix {
  @include clearfix(true);
}
osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
CreditAttribution: osopolar commented
Status: Active » Needs review
fubhy’s picture

fubhy CreditAttribution: fubhy commented
Assigned: Unassigned » msmithcti

Looks like our clearfix corrections definitely need some love. Will ask @splatio to take another look. Thanks.

fubhy’s picture

fubhy CreditAttribution: fubhy commented
Status: Needs review » Needs work
osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
CreditAttribution: osopolar commented
Version: 7.x-4.0-beta6 » 7.x-4.x-dev
FileSize
omega-starterkits-clearfix-2059009-5.patch732 bytes

The changes as patch for current dev.

msmithcti’s picture

msmithcti CreditAttribution: msmithcti commented
Status: Needs work » Fixed

Thanks for the patch. Clearfixes really did need some work:

  • _root.scss has been removed from the extended starterkit anyway
  • Our rewrite of core CSS includes a clearfix, so we don't need to provide it again in Ohm.
  • The clearfix in our rewrite of system.module did need some love. It now uses Compass for the clearfix (we were using Toolkit for the clearfix, when Compass has a perfectly good one)

Comitted in 4113f42. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gnucifer’s picture

gnucifer CreditAttribution: gnucifer commented
Status: Closed (fixed) » Needs work

It seems like clearfix(true) (which is toolkit's version of clearfix) is still used in ohm. The compass-clearfix-mixin gets overwritten when @import toolkit is run. Is this by design or would it be a better idea to use the compass clearfix in ohm as well?

Internet’s picture

Internet CreditAttribution: Internet commented
Issue summary: View changes
FileSize
clearfix-mixin-ohm-2059009-8.patch0 bytes

Clearfix changed to pie-clearfix

Internet’s picture

Internet CreditAttribution: Internet commented
Status: Needs work » Needs review

pie-clearfix mixin used

msmithcti’s picture

msmithcti CreditAttribution: msmithcti commented

Looks like that patch is an empty file. Could you upload the patch again?

steinmb’s picture

steinmb CreditAttribution: steinmb as a volunteer commented
Assigned: msmithcti » Unassigned
Status: Needs review » Needs work