backport of #new links patch

catch, do you know what changes need to be done to make normal links in 'Recent comments' block? I'm using patch from http://drupal.org/node/6162#comment-296152 , tracker and forum generate nice links to the new comments, it will be good to have such links in 'Recent comments' block.

I'va had that old thread open in a tab for days but haven't had a chance to work on backporting it. I need to work on a client site for a bit before I do any more active dev on the module. Will take another look at it then. Thanks. :)

Michelle

Well, I spent some time trying to get 'Recent comments' block work, but it still don't show links properly.
Here is the code:

Add to the comment.module:

function _pages_count($nid)
 {
    $pages = 0;
    $count = comment_num_all( $nid );
    $per_page = _comment_get_display_setting( 'comments_per_page' );

    if( $count > $per_page )
    {
        while( $count > $per_page )
        {
            $pages++;
            $count -= $per_page;
        }
        return 'page='.$pages;
    }
    else
    {
        return NULL;
    }

}

Changing some code within function theme_comment_block();
(just adding function call instead of the second NULL):

function theme_comment_block() {
  $items = array();
  foreach (comment_get_recent() as $comment) {
   
    $items[] = l($comment->subject, 'node/'. $comment->nid, NULL, _pages_count($comment->nid), 'comment-'. $comment->cid) .'<br />'. t('@time ago', array('@time' => format_interval(time() - $comment->timestamp)));
     }
  if ($items) {
    return theme('item_list', $items);
  }
}

The problem is that page number in the link is always = the max № of pages in the node:

If we have 3 page of comments, it always print
/node/4?page=2#here_we_have_comment_number

And even if the comment is on the first page (page=0), it still prints
/node/4?page=2#here_we_have_comment_number

I think function _pages_count should be changed somehow to always print page which belongs to the comment in the 'Recent comments' block.

Any ideas?

re the comment page module: I actually have that installed on the dev site but it's blocked on this issue. I had intended to put the link right next to the comment number as a permalink but can't figure out where the module is going wrong.

Michelle

This is fixed in 6.x and I've decided it's just not worth the effort to try and backport.

Michelle

LOL! I just realized while trying to fix another issue that I actually did backport this without realizing it. It was part of other code I backported. So I guess it's fixed. :)

Michelle