Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/ckeditor/lib/Drupal/ckeditor/Plugin/Editor/CKEditor.php

Line 85: Unused local variable $module_path
Line 265: Unused local variable $row_number

CommentFileSizeAuthor
#1 core-remove-unused-local-variables-ckeditor.php-2060715-1.patch1.1 KBlegolasbo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented
Assigned: legolasbo » Unassigned
Status: Active » Needs review
FileSize
core-remove-unused-local-variables-ckeditor.php-2060715-1.patch1.1 KB

Attached patch removes the unused variables

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Check both variables and they are unused

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Component: other » ckeditor.module
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Nice catches! Thanks :)

Automatically closed -- issue fixed for 2 weeks with no activity.