Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I'm testing this module and have run into a conundrum.
I can use jsminplus (the minifier coded in PHP) but my files take 0.1-1 second each to minify (except for jquery.min.js which takes 4s. When I use this minification, all is well on my site.
If I install the PHP extension using the C lib, the files take < 0.001 second each (less than one ms). However, when I do this, I get an error from the JS in the "context" module.
Now one could argue that the JS in the context module should be altered to not break minification from the PHP extension, but who knows if they would make that change. I'd rather not hack the JS myself, simply for reasons of ongoing maintenance/updates.
If this module offered a way to specify files that should ignore the minification, that would be a great way for me to work around this problem. I tried looking around in the module, but I can't find that implemented. Another reason why it might be nice to have such a feature would be for files that are already minified, so that they don't have to be run thru the minifier unnecessarily.
Thoughts?
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | advagg-2061339-5-per-file-css-compression.patch | 5.76 KB | mikeytown2 |
| #3 | advagg-2061339-per-file-js-compression.patch | 5.93 KB | mikeytown2 |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedLooks like there is an updated version of the C extension; I might end up pointing to this.
https://github.com/sqmk/pecl-jsmin
In the mean time it seems like having a way to specify this file should be compressed by X, this one by Y and ignore Z would be the way to go. I'll put it under a fieldset; use the same code for CSS as well.
Comment #2
brettbirschbach CreditAttribution: brettbirschbach commentedRegarding updating the C extension - perhaps not a bad idea. The one you have referenced currently I pulled down, but it has a compile error when I try to build it on my mac (a non-void function with a plain "return;" statement). I had to fix the source in order to get it to build. When I built it on a different machine I didnt get the error, so I'm guessing some compilers are less picky. Had I not known what I was doing with jumping into the C code to fix my compile problem, I may have given up on that possibility prematurely, which is a shame since it is so very very very much faster than the straight PHP minifier.
Comment #3
mikeytown2 CreditAttribution: mikeytown2 commentedFollowing patch has been committed. Let me know if you've tested out the newer C extension.
Comment #4
mikeytown2 CreditAttribution: mikeytown2 commentedComment #5
mikeytown2 CreditAttribution: mikeytown2 commentedFollowing patch has been committed.
Comment #6
brettbirschbach CreditAttribution: brettbirschbach commentedWow, now that's a fast turnaround. Thanks mikey! I have not tested the new C lib - I simply tested with the one that you had referenced, and never looked beyond that.
Comment #7
mikeytown2 CreditAttribution: mikeytown2 commented