Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/menu/lib/Drupal/menu/Plugin/Block/MenuBlock.php

Line 30: Unused local variable $plugin

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

manu4543’s picture

Status: Active » Needs review
FileSize
576 bytes

Attached patch removed Unused local variable $plugin in line 30

sergeypavlenko’s picture

Assigned: manu4543 » Unassigned
Status: Needs review » Reviewed & tested by the community

All right.

Dries’s picture

In this case, it actually decreases the readability of the code in my opinion. The variable is unused but it is helpful to understand the format of the data.

webchick’s picture

Status: Reviewed & tested by the community » Needs review

Agreed.

manu4543’s picture

Status: Needs review » Closed (won't fix)

Actually yes, it makes more sense to not remove that variable.