Super grateful for this module!

Sooo... maybe I missed some configuration here but I noticed that I can subscribe to various taxonomy terms on the user page (here: user/1/subscriptions/taxa).

But there is some additional functionality that maybe got missed (?) or I have configured something wrong here.

* Cannot subscribe a term through subscription block (as you can with content) when viewing a term page
* Cannot subscribe to a term at bottom of each node output (on term page) at bottom

Thoughts?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

salvis’s picture

Subscribing in the 'Subscribe' block or fieldset should work just fine on node/% pages, but there's no such feature on term/% pages.

ShaneOnABike’s picture

Status: Active » Needs review
FileSize
3.54 KB

Yeah unfortunately I was referring to term pages. I added the hook in this patch although it doesn't expose the entire block I figure it's a start. It also determines if there should be a subscribe / unsubscribe link by checkin the db.

Status: Needs review » Needs work

The last submitted patch, 2061683-term-subscribe-3.patch, failed testing.

salvis’s picture

Category: bug » feature
--- a/subscriptions/subscriptions_taxonomy.module	2013-06-18 11:28:21.000000000 -0400
+++ b/subscriptions/subscriptions_taxonomy.module	2013-08-28 15:24:14.057582083 -0400
@@ -132,6 +132,73 @@

Patches need to be based in the module's directory.

RaulMuroc’s picture

Priority: Normal » Major
Issue summary: View changes

This should be major feature or the module is losing potential users. Is really an interesting feature and even necessary.

The mentality of end-user is of " ok, i go at that term page to visit and see it, for example #NewYork and look, i like it really a lot and wish to subscribe to have the new, i will subscribe in it... wait a minute: where the f*** is a subscribe button????"

That's the user-mentality and that's what we need to cover "fastly" so major issue.

iamEAP’s picture

Attaching #2 as a valid patch. Keeping it set to "Needs Work" because it's still missing quite a bit, in my opinion.

Notably, there's no way to disable this functionality (as there is with the node version). It'd also be nice to get the existing block to work for any node/% or taxonomy/term/% path.

iamEAP’s picture

Status: Needs work » Needs review
FileSize
8.34 KB

More fully implemented patch for review.

RaulMuroc’s picture

I applied patch and wanted to subscribe in page of type:

statuses/term/*

But doesn't appear 'subscribe' link nowhere. :S

iamEAP’s picture

It defaults to not showing (because we don't want it to suddenly appear when people update to the latest module).

You can either, keep the configuration as is, and place the block on your term page. Or, you can change the configuration on the admin page for this module, so that it shows without having to place the block.

salvis’s picture

Priority: Major » Normal
Status: Needs review » Needs work

Thank you for the update.

I wonder whether it would make sense to create a separate subscriptions_taxonomy_ui.module. Maybe subscriptions_ui.module should have been called subscriptions_content_ui.module or subscriptions_node_ui.module in the first place. Maybe we can factor out some common code into a subscriptions_ui.inc file to avoid duplication?

subscriptions_ui.module is a leaf in the dependency tree of the Subscriptions modules, and Subscriptions is designed to also work without it. I'd still like to get an alternative UI module that essentially just implements a JS button or link like the [Follow] button here on d.o.

Adding subscriptions_ui as a dependency in subscriptions_taxonomy.info is definitely undesirable.

iamEAP’s picture

Ah, definitely understand the desire to separate out those dependencies; not something I realized, having just started using the module a couple hours before patching. One of the difficulties I ran into when trying out the module was knowing when to enable which modules, so I'd prefer not to increase the number of modules with a taxonomy-specific UI module.

I'll take a look again and see if I can achieve the same thing I want without the undesirable dependency.

RaulMuroc’s picture

Sorry but tried also adding the block in the status/term/* page and nothing appears. <-- This vocabulary terms are working through module status module so perhaps we are working about Subscriptions & Statuses integration. Another issue with feature request?

RaulMuroc’s picture

No more testing from others? My latest test with the patch didn't work but is true that in my case I have a particular situation where I wish a subscription option for Statuses taxonomies.

Thank you.

petednz’s picture

This does seem like a great option to offer. Any update on this?

Otherwise I will go test the patch in #7 while taking note of Salvis' comments in #8