Part of #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']

core/modules/node/lib/Drupal/node/Access/NodeRevisionAccessCheck.php
fix of $account = $GLOBALS['user'];

Files: 
CommentFileSizeAuthor
#5 node-revision-access-check-remove-global-user-2062117-5.patch641 bytesm1r1k
PASSED: [[SimpleTest]]: [MySQL] 58,635 pass(es).
[ View ]
#3 2062117-3.patch666 bytesanpolimus
FAILED: [[SimpleTest]]: [MySQL] 57,859 pass(es), 7 fail(s), and 2 exception(s).
[ View ]
#2 2062117-2.patch665 bytesanpolimus
FAILED: [[SimpleTest]]: [MySQL] 5,851 pass(es), 1,521 fail(s), and 103 exception(s).
[ View ]
#1 2062117-1.patch666 bytesanpolimus
FAILED: [[SimpleTest]]: [MySQL] 57,787 pass(es), 9 fail(s), and 2 exception(s).
[ View ]

Comments

StatusFileSize
new666 bytes
FAILED: [[SimpleTest]]: [MySQL] 57,787 pass(es), 9 fail(s), and 2 exception(s).
[ View ]

REplaced global $user with get account method.

StatusFileSize
new665 bytes
FAILED: [[SimpleTest]]: [MySQL] 5,851 pass(es), 1,521 fail(s), and 103 exception(s).
[ View ]

test2

Status:Active» Needs review
StatusFileSize
new666 bytes
FAILED: [[SimpleTest]]: [MySQL] 57,859 pass(es), 7 fail(s), and 2 exception(s).
[ View ]

replased with new \Drupal::request()->attributes->get('_account');

Status:Needs review» Needs work

The last submitted patch, 2062117-3.patch, failed testing.

StatusFileSize
new641 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,635 pass(es).
[ View ]

Status:Needs work» Needs review

Push to retesting

Assigned:anpolimus» Unassigned
Status:Needs review» Reviewed & tested by the community
Issue tags:+Quick fix

This one looks good to go and applies cleanly as of today.

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.