Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

I think you're right. Good catch!

jlindsey15’s picture

Assigned: Unassigned » jlindsey15
Status: Active » Needs review
FileSize
533 bytes

Patch for Drupal 8.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, thanks! I'll get this committed. Most likely I can use the same patch for D7 too.

jhodgdon’s picture

Version: 8.x-dev » 6.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks! Committed to 8.x and 7.x.

In 6.x for consistency we should probably say "Implementation of.." rather than "Implements" (the rest of 6.x uses the old standard). So if someone still cares to port this to 6.x...

rhm5000’s picture

Assigned: jlindsey15 » rhm5000
Status: Patch (to be ported) » Needs review
FileSize
404 bytes

Backport to 6.x.

jhodgdon’s picture

Status: Needs review » Needs work

Thanks! But this patch is not quite right. Look at the 8.x/7.x patch on #2 -- we need to *replace* the existing function body.

rhm5000’s picture

The function body, everything within {}, is unchanged in patch on #2. I provided another patch to reflect the removed comments in #2 patch.

rhm5000’s picture

Status: Needs work » Needs review
jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, that is the patch we needed. I will get it committed sometime soon.

jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 6.x.

Automatically closed -- issue fixed for 2 weeks with no activity.