Part of meta-issue #2052421: [META] Rename Views properties to core standards

CommentFileSizeAuthor
#8 drupal-views-properties-rename-2062131-8.patch1.94 KBNonProfit
#3 drupal-views-properties-rename-2062131-2.patch1.92 KBdanylevskyi
#1 drupal-views-properties-rename-2062131.patch1.92 KBdanylevskyi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
CreditAttribution: danylevskyi commented
Assigned: danylevskyi » Unassigned
Status: Active » Needs review
FileSize
drupal-views-properties-rename-2062131.patch1.92 KB
danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
CreditAttribution: danylevskyi commented
Assigned: Unassigned » danylevskyi
Status: Needs review » Needs work
danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
CreditAttribution: danylevskyi commented
Assigned: danylevskyi » Unassigned
Status: Needs work » Needs review
FileSize
drupal-views-properties-rename-2062131-2.patch1.92 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

That is perfect, thank you very much!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Needs reroll

git ac https://drupal.org/files/drupal-views-properties-rename-2062131-2.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1967  100  1967    0     0   5890      0 --:--:-- --:--:-- --:--:--  7963
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/MachineName.php:68
error: core/modules/views/lib/Drupal/views/Plugin/views/field/MachineName.php: patch does not apply
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Needs reroll

Adding tag.

NonProfit’s picture

NonProfit CreditAttribution: NonProfit commented
Assigned: Unassigned » NonProfit
NonProfit’s picture

NonProfit CreditAttribution: NonProfit commented
Status: Needs work » Needs review
FileSize
drupal-views-properties-rename-2062131-8.patch1.94 KB

Followed instructions on https://drupal.org/patch/reroll. On step #7 it did a three-way merge and it automagically did not identify any conflicts.

NonProfit’s picture

NonProfit CreditAttribution: NonProfit commented
Assigned: NonProfit » Unassigned
Issue tags: -Needs reroll

Patch passed.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.