Files: 
CommentFileSizeAuthor
#4 20620153-rename-views-properties-4.patch5 KBrhm50
PASSED: [[SimpleTest]]: [MySQL] 58,308 pass(es).
[ View ]
#1 rename-views-properties.patch567 byteschertzog
FAILED: [[SimpleTest]]: [MySQL] 58,768 pass(es), 37 fail(s), and 43 exception(s).
[ View ]

Comments

Assigned:danylevskyi» Unassigned
Status:Active» Needs review
StatusFileSize
new567 bytes
FAILED: [[SimpleTest]]: [MySQL] 58,768 pass(es), 37 fail(s), and 43 exception(s).
[ View ]

Patch attached.

Status:Needs review» Needs work

The last submitted patch, rename-views-properties.patch, failed testing.

This does not work, because once you rename a variable you have to rename all usages of all base and subclasses too.

Status:Needs work» Needs review
StatusFileSize
new5 KB
PASSED: [[SimpleTest]]: [MySQL] 58,308 pass(es).
[ View ]

New Patch.

Status:Needs review» Reviewed & tested by the community

Good work!

Status:Reviewed & tested by the community» Fixed

Committed 8dd8210 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.