Files: 
CommentFileSizeAuthor
#3 rename_views_properties_to_core_standards-2062157-3.patch543 bytesundertext
PASSED: [[SimpleTest]]: [MySQL] 58,516 pass(es).
[ View ]
#1 2062157-1.patch1.71 KBGarbar
PASSED: [[SimpleTest]]: [MySQL] 57,976 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new1.71 KB
PASSED: [[SimpleTest]]: [MySQL] 57,976 pass(es).
[ View ]

need reviews

Status:Needs review» Needs work

Thanks for your patch!

@@ -42,9 +42,9 @@ class ViewsBlock implements ContainerDerivativeInterface {
-  public static function create(ContainerInterface $container, $base_plugin_id) {
+  public static function create(ContainerInterface $container, $basePluginId) {
...
+      $basePluginId,
@@ -52,13 +52,13 @@ public static function create(ContainerInterface $container, $base_plugin_id) {
-   * @param string $base_plugin_id
+   * @param string $basePluginId
...
+  public function __construct($basePluginId, EntityStorageControllerInterface $view_storage_controller) {
+    $this->basePluginId = $basePluginId;

The property on the object should be $basePluginId (as you did it), but the method parameters should be $base_plugin_id.

Status:Needs work» Needs review
StatusFileSize
new543 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,516 pass(es).
[ View ]

Status:Needs review» Reviewed & tested by the community

This is fine!

Category:task» bug
Status:Reviewed & tested by the community» Fixed

Committed 983bdab and pushed to 8.x. Thanks!

Reclassifying this to bug because it is.

Automatically closed -- issue fixed for 2 weeks with no activity.