Files: 
CommentFileSizeAuthor
#23 global-user-node-2062791-23.patch6.64 KBnatemow
PASSED: [[SimpleTest]]: [MySQL] 59,284 pass(es).
[ View ]
#22 global-user-node-2062791-21.patch6.64 KBnatemow
PASSED: [[SimpleTest]]: [MySQL] 59,179 pass(es).
[ View ]
#20 2062791-20-global-user-node.patch7.69 KBjoelpittet
FAILED: [[SimpleTest]]: [MySQL] 58,998 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#14 2062791-14-global-user-node.patch8.09 KBjoelpittet
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2062791-14-global-user-node.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#12 interdiff.txt6.97 KBjoelpittet
#12 2062791-12-global-user-node.patch8.57 KBjoelpittet
FAILED: [[SimpleTest]]: [MySQL] 58,411 pass(es), 12 fail(s), and 0 exception(s).
[ View ]
#10 node-module-remove-global-user-2062791-10.patch1.9 KBm1r1k
FAILED: [[SimpleTest]]: [MySQL] 58,702 pass(es), 12 fail(s), and 0 exception(s).
[ View ]
#5 drupal8.node-module.2062791-5.patch2.3 KBsergeypavlenko
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal8.node-module.2062791-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 drupal8.node-module.2062791-3.patch1.89 KBsergeypavlenko
FAILED: [[SimpleTest]]: [MySQL] 57,291 pass(es), 43 fail(s), and 8 exception(s).
[ View ]
#1 rename-global-user-2062791-1.patch1.78 KBjlindsey15
FAILED: [[SimpleTest]]: [MySQL] 57,665 pass(es), 8 fail(s), and 2 exception(s).
[ View ]

Comments

Assigned:jlindsey15» Unassigned
Status:Active» Needs review
StatusFileSize
new1.78 KB
FAILED: [[SimpleTest]]: [MySQL] 57,665 pass(es), 8 fail(s), and 2 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, rename-global-user-2062791-1.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.89 KB
FAILED: [[SimpleTest]]: [MySQL] 57,291 pass(es), 43 fail(s), and 8 exception(s).
[ View ]

Please make sure you have the correct comment?

Status:Needs review» Needs work

The last submitted patch, drupal8.node-module.2062791-3.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.3 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal8.node-module.2062791-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Needs work

The last submitted patch, drupal8.node-module.2062791-5.patch, failed testing.

For easy tracking

Status:Needs work» Needs review
Issue tags:-blocked-by-request-scope

#5: drupal8.node-module.2062791-5.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+blocked-by-request-scope

The last submitted patch, drupal8.node-module.2062791-5.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.9 KB
FAILED: [[SimpleTest]]: [MySQL] 58,702 pass(es), 12 fail(s), and 0 exception(s).
[ View ]

Updated patch:

Status:Needs review» Needs work

The last submitted patch, node-module-remove-global-user-2062791-10.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new8.57 KB
FAILED: [[SimpleTest]]: [MySQL] 58,411 pass(es), 12 fail(s), and 0 exception(s).
[ View ]
new6.97 KB

There seemed to be a few more missing. I hope this is right. Interdiff from #10

Status:Needs review» Needs work

The last submitted patch, 2062791-12-global-user-node.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new8.09 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2062791-14-global-user-node.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Re-rolled, manually.

The last submitted patch, 2062791-14-global-user-node.patch, failed testing.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 14: 2062791-14-global-user-node.patch, failed testing.

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 14: 2062791-14-global-user-node.patch, failed testing.

Issue summary:View changes
Status:Needs work» Needs review
Parent issue:» #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']
StatusFileSize
new7.69 KB
FAILED: [[SimpleTest]]: [MySQL] 58,998 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Re-rolled.

Status:Needs review» Needs work

The last submitted patch, 20: 2062791-20-global-user-node.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new6.64 KB
PASSED: [[SimpleTest]]: [MySQL] 59,179 pass(es).
[ View ]

Re-rolled.

StatusFileSize
new6.64 KB
PASSED: [[SimpleTest]]: [MySQL] 59,284 pass(es).
[ View ]

Re-rolled.

Status:Needs review» Reviewed & tested by the community

Nice work @natemow #23 is ready to ship.

Double checked to see if there were any global $user or $GLOBALS['user'] in the node module and it's clean.

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.