If I use the commons browsing widget and filter to view just posts, then the comment and follow buttons vanish. The desired appearance is exemplified by using commons BW to show all content. In that case posts appear with comment and follow buttons beneath the teaser.

I see this with RC2 from this morning (and previous dev versions I have checked)

Here is what a post should look like:
with buttons

And here is how a post appears when other non-posts are filtered out:
without buttons

CommentFileSizeAuthor
#7 bw_all.png171.27 KBDevin Carlson
#7 bw_posts.png169.2 KBDevin Carlson
#6 add-links-to-browsing-widget-node-teasers-1932530-24.patch4.49 KBDevin Carlson
#2 Groups_detail_-_all_-_refineby_opened_-_hover.png73.83 KBezra-g
commons-bw-posts.PNG39.87 KBbehoppe333
commons-bw-all.PNG41.4 KBbehoppe333
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry commented
Issue tags: +Commons 7.x-3.3 radar

Tagging radar, I'm hoping its just something missing from a view display :-)

ezra-g’s picture

ezra-g CreditAttribution: ezra-g commented
Status: Active » Postponed (maintainer needs more info)
FileSize
Groups_detail_-_all_-_refineby_opened_-_hover.png73.83 KB

I believe it is by design that the follow and small comment buttons don't appear in teaser views . @behoppe333 can you share why you believe they should appear?

We're actually missing the "call to action' buttons from the designs. I suspect this probably isn't necessarily a 3.3 radar issue.
Groups_detail_-_all_-_refineby_opened_-_hover.png

behoppe333’s picture

behoppe333 CreditAttribution: behoppe333 commented
Status: Active » Postponed (maintainer needs more info)

Thanks japerry and ezra-g

  1. I really like the theme illustrated in #2. Can we have that please! :-)
  2. Instead what I see is illustrated by my original post. Most content type teasers have neither prominent calls to action (green button) nor clear indicators of activity ("4 answers"). This is a major shortcoming IMO and I am curious why the actual Commons Origins differs from the illustration in #2
  3. One way to re-state my bug report is: When a user filters on a specific content type with commons_bw, calls to action and indicators of activity on the displayed content type should be at least as clear as they were in the generic view of commons_bw_all. Instead, in the case of posts, the clarity of both call to action and indication of activity degrade significantly.
  4. My reasoning is based on
  • Ease of use: When user is looking at teaser in commons_bw, she should have single-click access to important actions related to that content item (answering, commenting, following, voting, etc.)
  • Consistency: When user switches from commons_bw_all to a filtered view of one content type, he should not have to wonder which links and buttons will appear or disappear from the teasers. Right now each content type undergoes a slightly different transformation (between "all" view and content-specific view) and so it is unnecessarily complicated trying to figure out which links and buttons appear/disappear.

I sense some disconnect between me and ezra-g --- mostly because the illustration in #2 is exactly what I want, and the reality of rc2 is so different from that. [Edit: After re-reading ezra-g in #2, I think what I am saying is "yes please add the call to action buttons that are in your designs, and make that a 3.3 radar issue"]

Here are some miscellaneous other related bits

  • In my instance, I modified commons_bw_all view to include events. Interestingly, the event teasers show up in the view with the nifty green buttons and a display of how many are attending. That is consistent with illustration in #2. Can we have all content types work this way?
  • The worst teaser IMO is the Question teaser. It has neither any call to action (Answer button) nor any indicator of activity ("4 answers")
  • The Question teaser is the only one that appears the same when switching from "all" view to content-specific filtered view. It has a "follow" button in both cases.
  • For polls, the "Vote" button appears in both cases but the "follow" button appears only in the "all" view.
  • For posts, both the little comment indicator and the follow button appear only in the "all" view and vanish from the content-specific filtered view

I hope this helps

behoppe333’s picture

behoppe333 CreditAttribution: behoppe333 commented
Status: Postponed (maintainer needs more info) » Active

Changing back to active

ezra-g’s picture

ezra-g CreditAttribution: ezra-g commented
Status: Postponed (maintainer needs more info) » Active
Issue tags: -Commons 7.x-3.3 radar +Commons 7.x-3.4 radar

Thanks for that feedback. Since this is not a regression and we're close to the release target, I'm removing from the 3.3 radar.

Let's consider this for 3.4.

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Component: Posts » Code
Status: Active » Needs review
FileSize
add-links-to-browsing-widget-node-teasers-1932530-24.patch4.49 KB

A patch to add links to node teasers inside of the browsing widget for Documents, Polls and Posts. Update functions are included to revert the BW views for each Commons module associated with the content type.

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
FileSize
bw_posts.png169.2 KB
bw_all.png171.27 KB

Screenshots of the issue: links are displayed for nodes in the commons_bw_all view but not for the individual commons_bw_* (posts, documents, polls, etc). For consistency, links should either be displayed in all of the browsing widget views or in none of them.

Links are displayed in the "all" tab of the browsing widget:

bw_all.png

Links aren't displayed in the "posts" tab of the browsing widget:

bw_posts.png

ezra-g’s picture

ezra-g CreditAttribution: ezra-g commented
Component: Code » Theme
Status: Needs review » Needs work

I believe that the correct state is "needs work" per #2.

behoppe333’s picture

behoppe333 CreditAttribution: behoppe333 commented

Thanks for posting patch, Devin Carlson.

I know very little about git, and so before I learn how to apply a patch, can you please confirm that I should be able to apply the patch in #6 to the 7.x-3.3 release (i.e., not 3.x-dev)?

ezra-g’s picture

ezra-g CreditAttribution: ezra-g commented
Issue tags: -Commons 7.x-3.4 radar

Realistically, I think we'll address this post 3.4.

charlie charles’s picture

charlie charles CreditAttribution: charlie charles commented

Hi ezra-g
I've been try do the same as you
adding the name under the user picture.
But when I add the $name if float to the right
instead of the left

What I've done is

1.Copy the node.tpl.php
2.Found the template I wanted to edit using Devel Themer
2.renamed node.tpl.php to node--view--commons-events-upcoming-events.tpl.php
3.Added the print $name; as shown below

<?php if(!empty($user_picture) || $display_submitted): ?>
    <footer<?php print $footer_attributes; ?>>
      <?php print $user_picture; ?> 

   <?php print $name; ?> 
      
    
      <p class="author-datetime"><?php print $submitted; ?></p>
    </footer>
  <?php endif; ?>

But the name float to the right instead of the left
even through it's in the same DIV as print $user_picture;
Many Thanks for your help

charlie charles’s picture

charlie charles CreditAttribution: charlie charles commented

It's ok I figured out how to do it using panelizer! :)

WebSinPat’s picture

WebSinPat CreditAttribution: WebSinPat commented

I accidentally submitted a dupe of this issue #2159333: browsing widget does not display node-action-links when you click on the "posts" tab
but end result being that we got a patch and commit over there!

@behoppe333
The patch in that issue at https://drupal.org/comment/8299529#comment-8299529 works for me on my production commons3.3 site. (I would recommend using that one instead of the one in this thread since that one is committed, and i think this one has a typo in it.)
if you still need help figuring out how to apply the patch, here's what I did. assuming you have a command line to work with

#this is the path to commons modules in 3.3  It changes in a later release
% cd profiles/commons/modules/contrib
% wget http://drupal.org/files/issues/standardize-browsing-widget-row-links-2159333-4.patch
% patch -p3 < standardize-browsing-widget-row-links-2159333-4.patch
%  drush updb

Also, I agree with the points raised by @behoppe333 in #2, regarding some thoughts on the usefulness of the links provided per content type.
EDIT: perhaps we should close this as fixed per the commit in the other issue, and open a new feature request for getting some more action links? and the added info provided in @ezra-g's theme/screenshot above?

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Title: commons_bw view of posts omits "comments" and "follow" buttons » Add "call to action" buttons to the browsing widget views
Category: Bug report » Task
Issue summary: View changes
Related issues: +#2159333: browsing widget does not display node-action-links when you click on the "posts" tab

Retitling based on #2, since the inconsistent display of node links was addressed in #2159333: browsing widget does not display node-action-links when you click on the "posts" tab.

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
rosemeria’s picture

rosemeria CreditAttribution: rosemeria commented

Hi Devin
FYI - Adding "Green Action Buttons" to BW teaser view should take care of this issue item too.
Issue concerning Q&A teaser node:
Question full node has action button, but should be on teaser view

These action buttons will greatly enhance the users experience with Commons' activity streams. Thanks for looking into this theming feature.

rosemeria’s picture

rosemeria CreditAttribution: rosemeria commented

"call to action" buttons for 3.14...
Pretty please