API page: https://api.drupal.org/api/drupal/includes%21database%21select.inc/funct...

return call_user_func_array(array($this->query, 'hasAnyTags'), $args);
Shouldn't this call use 'hasAnyTag'? (without the s)

CommentFileSizeAuthor
#8 2065917-d8-fix_extender_hasAnyTag_and_add_tests.patch2.63 KBandrewbelcher
#8 2065917-d7-fix_extender_hasAnyTag_and_add_tests.patch2.43 KBandrewbelcher
#4 SelectQueryExtender_hasAnyTag-2065917-4-tests.patch1.18 KBSpadXIII
#2 SelectQueryExtender-hasAnyTags-2065917-2.patch524 byteskboopathi
#1 SelectQueryExtender_hasAnyTag-2065917-1.patch524 bytesSpadXIII
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SpadXIII’s picture

SpadXIII CreditAttribution: SpadXIII commented
FileSize
SelectQueryExtender_hasAnyTag-2065917-1.patch524 bytes

Small patch file

kboopathi’s picture

kboopathi CreditAttribution: kboopathi commented
Status: Active » Needs review
FileSize
SelectQueryExtender-hasAnyTags-2065917-2.patch524 bytes

patch

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Don't we need tests?

SpadXIII’s picture

SpadXIII CreditAttribution: SpadXIII commented
FileSize
SelectQueryExtender_hasAnyTag-2065917-4-tests.patch1.18 KB

Created a quick test-patch that shows just this issue and that the patch works.

Status: Needs review » Needs work

The last submitted patch, SelectQueryExtender_hasAnyTag-2065917-4-tests.patch, failed testing.

MrHaroldA’s picture

MrHaroldA CreditAttribution: MrHaroldA commented
Status: Needs work » Reviewed & tested by the community

The previous state was invalid, it should have been 'needs review', which I did ;)

The patch in #1 (and #2) fixes all warnings.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Version: 7.x-dev » 8.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs backport to D7

This would need to go into Drupal 8 first.

Also, there should be a single patch (with the fix and tests) to make sure that the test actually passes with the fix applied.

andrewbelcher’s picture

andrewbelcher CreditAttribution: andrewbelcher commented
Status: Needs work » Needs review
FileSize
2065917-d7-fix_extender_hasAnyTag_and_add_tests.patch2.43 KB
2065917-d8-fix_extender_hasAnyTag_and_add_tests.patch2.63 KB

Here are patches for D8 and D7 including test coverage.

The last submitted patch, 8: 2065917-d7-fix_extender_hasAnyTag_and_add_tests.patch, failed testing.

andrewbelcher’s picture

andrewbelcher CreditAttribution: andrewbelcher commented
Version: 8.x-dev » 7.x-dev

Testing D7 patch.

andrewbelcher’s picture

andrewbelcher CreditAttribution: andrewbelcher commented

8: 2065917-d7-fix_extender_hasAnyTag_and_add_tests.patch queued for re-testing.

andrewbelcher’s picture

andrewbelcher CreditAttribution: andrewbelcher commented
Version: 7.x-dev » 8.x-dev

Back to D8.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Reviewed & tested by the community

Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed 34bb38f and pushed to 8.x. Thanks!

MrHaroldA’s picture

MrHaroldA CreditAttribution: MrHaroldA commented

There's already a D7 patch in #8.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

8: 2065917-d7-fix_extender_hasAnyTag_and_add_tests.patch queued for re-testing.

andrewbelcher’s picture

andrewbelcher CreditAttribution: andrewbelcher commented
Status: Patch (to be ported) » Reviewed & tested by the community

The patch is already made for D7 (#8) which passes tests and is more or less identical to the D8 one which has already been reviewed. Would be great to get this in as it's filling my error logs and making query alters a bit tricky!

The last submitted patch, 8: 2065917-d7-fix_extender_hasAnyTag_and_add_tests.patch, failed testing.

MrHaroldA’s picture

MrHaroldA CreditAttribution: MrHaroldA commented

8: 2065917-d7-fix_extender_hasAnyTag_and_add_tests.patch queued for re-testing.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.