Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Error-on-enable seems to be the consensus, but if configurable (see issue #2066061: Permit other path than "/data" and "/data.json"), should also be error-on-(mis-)configure.
Comments
Comment #1
bhosmer CreditAttribution: bhosmer commentedhook_install to verify if the path exists already.
Comment #2
bhosmer CreditAttribution: bhosmer commentedCompleted with 1786cf99f516
Comment #3
Barrett CreditAttribution: Barrett commentedThis doesn't seem to be working. On a clean install, I created a view with path /data, then enabled the opendata_view and opendata module and got no error reported.
Comment #4
Barrett CreditAttribution: Barrett commentedI also think this should move from opendata to opendata_view. Unless a user enables our view, we don't care if they have anything at /data
Comment #5
bhosmer CreditAttribution: bhosmer commentedLet me check this out with the latest and see where the problem is.
Comment #6
bhosmer CreditAttribution: bhosmer commentedCan someone give me commit access? I had it for the sandbox, but I don't seem to have it here.
I've made the changes, and I just need to push them up for testing.
Comment #7
Barrett CreditAttribution: Barrett commentedSorry for the hold up, @bhosmer. You should have commit access now.
Thanks for sticking with the project.
Comment #8
bhosmer CreditAttribution: bhosmer commentedThanks Barrett. I've pushed this 72099d1b up.
Comment #9
Barrett CreditAttribution: Barrett commentedSorry, bhosmer. I feel like I keep running you in circles.
The update does what's expected of it. The problem is that the code for data.json moved from the views submodule to the main module. I'm ambivalent as to where it should be, but either the data.json code needs to move back to the views submodule or the install hook that checks for it needs to move back to the main module.
Comment #10
bhosmer CreditAttribution: bhosmer commentedSure thing.
I've put it back in
opendata.install
with b4faa69431f.Comment #11
Barrett CreditAttribution: Barrett commentedLooks good, @bhosmer. Thanks for your continuing work on this project.