Files: 
CommentFileSizeAuthor
#18 2066445-ajax_test_controller-14.patch5.45 KBalvar0hurtad0
FAILED: [[SimpleTest]]: [MySQL] 63,042 pass(es), 21 fail(s), and 64 exception(s).
[ View ]
#15 2066445-ajax_test-controller-15.patch12.15 KBrahulbile
FAILED: [[SimpleTest]]: [MySQL] 63,039 pass(es), 8 fail(s), and 1 exception(s).
[ View ]
#11 2066445-ajax_test-controller-11.patch11.71 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 59,746 pass(es), 8 fail(s), and 1 exception(s).
[ View ]
#5 drupal8.system-module.2066445-5.patch7.66 KBmparker17
FAILED: [[SimpleTest]]: [MySQL] 58,136 pass(es), 8 fail(s), and 12 exception(s).
[ View ]
#5 interdiff.txt932 bytesmparker17
#3 drupal8.system-module.2066445-3.patch7.73 KBmparker17
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/tests/modules/ajax_test/lib/Drupal/ajax_test/Controller/AjaxTestAjaxController.php.
[ View ]
#3 interdiff.txt2.68 KBmparker17
#1 system-ajax_test-ajax_test_ajax_controller-2066445-1.patch7.53 KBmparker17
PASSED: [[SimpleTest]]: [MySQL] 57,884 pass(es).
[ View ]

Comments

Assigned:mparker17» Unassigned
Status:Active» Needs review
StatusFileSize
new7.53 KB
PASSED: [[SimpleTest]]: [MySQL] 57,884 pass(es).
[ View ]

Try this...

Status:Needs review» Needs work
  1. +++ b/core/modules/system/tests/modules/ajax_test/ajax_test.routing.yml
    @@ -10,3 +10,27 @@ ajax_test_dialog_form:
    +ajax_test_dialog_close:
    +  pattern: 'ajax-test/dialog-close'
    +  defaults:
    +    _controller: '\Drupal\ajax_test\Controller\AjaxTestAjaxController::dialogClose'
    +  requirements:
    +    _access: 'TRUE'
    +ajax_test_dialog_render:
    +  pattern: 'ajax-test/render'
    +  defaults:
    +    _controller: '\Drupal\ajax_test\Controller\AjaxTestAjaxController::dialogRender'
    +  requirements:
    +    _access: 'TRUE'
    +ajax_test_dialog_order:
    +  pattern: 'ajax-test/order'
    +  defaults:
    +    _controller: '\Drupal\ajax_test\Controller\AjaxTestAjaxController::dialogOrder'
    +  requirements:
    +    _access: 'TRUE'
    +ajax_test_dialog_error:
    +  pattern: 'ajax-test/render-error'
    +  defaults:
    +    _controller: '\Drupal\ajax_test\Controller\AjaxTestAjaxController::dialogError'
    +  requirements:
    +    _access: 'TRUE'

    lets add a blank line between each route. Makes it more legible

  2. +++ b/core/modules/system/tests/modules/ajax_test/lib/Drupal/ajax_test/Controller/AjaxTestAjaxController.php
    @@ -0,0 +1,72 @@
    +    if (!empty($_GET['message'])) {
    +      $message = $_GET['message'];

    If you pass $request as an argument to this, these can be accessed via the request object.

Status:Needs work» Needs review
StatusFileSize
new2.68 KB
new7.73 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/system/tests/modules/ajax_test/lib/Drupal/ajax_test/Controller/AjaxTestAjaxController.php.
[ View ]

Try this...

Status:Needs review» Needs work

The last submitted patch, drupal8.system-module.2066445-3.patch, failed testing.

StatusFileSize
new932 bytes
new7.66 KB
FAILED: [[SimpleTest]]: [MySQL] 58,136 pass(es), 8 fail(s), and 12 exception(s).
[ View ]

Whoops... that empty() language construct gets me every time.

Let's try this instead.

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:-WSCCI-conversion

The last submitted patch, drupal8.system-module.2066445-5.patch, failed testing.

Status:Needs work» Needs review

#5: drupal8.system-module.2066445-5.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+WSCCI-conversion

The last submitted patch, drupal8.system-module.2066445-5.patch, failed testing.

Thanks for your work on this issue! Please see #1971384-43: [META] Convert page callbacks to controllers for an update on the routing system conversion process.

Status:Needs work» Needs review
StatusFileSize
new11.71 KB
FAILED: [[SimpleTest]]: [MySQL] 59,746 pass(es), 8 fail(s), and 1 exception(s).
[ View ]

Re-rolling with current conversion changes...

The last submitted patch, 2066445-ajax_test-controller-11.patch, failed testing.

Seems valid fails... seems test trying to see the js data loaded by drupal_add_js() but this has been changed. Not sure how to proceed further here... may need to update test case?

Issue summary:View changes
Issue tags:+Needs reroll

needs a reroll, instructions: https://drupal.org/contributor-tasks/reroll

Status:Needs work» Needs review
Issue tags:-Needs reroll
StatusFileSize
new12.15 KB
FAILED: [[SimpleTest]]: [MySQL] 63,039 pass(es), 8 fail(s), and 1 exception(s).
[ View ]

Re-rolling with current conversion changes.

Status:Needs review» Needs work

The last submitted patch, 15: 2066445-ajax_test-controller-15.patch, failed testing.

Rerolled patch

Status:Needs work» Needs review
StatusFileSize
new5.45 KB
FAILED: [[SimpleTest]]: [MySQL] 63,042 pass(es), 21 fail(s), and 64 exception(s).
[ View ]

Status:Needs review» Needs work

The last submitted patch, 18: 2066445-ajax_test_controller-14.patch, failed testing.

#1971384: [META] Convert page callbacks to controllers has this as replacing ajax_test_dialog_close and other callbacks, but they aren't removed by the patch and there are no changes to \Drupal\ajax_test\Controller\AjaxTestController which I'd expect to see.

If this is the right issue to update that class, please can we also correct the docblock for ajax_test_dialog that was missed in #1987606: Convert ajax_test_dialog() to a new style controller

Assigned:Unassigned» Gokul N K