Found in
Updated: Comment #0
Problem/Motivation
Editor module allows to specify the weight and height of uploaded images and uses the HTML placeholder attribute to create a "[width] x [height] pixels" interface.
These placeholders are not translated.
See http://drupalcode.org/project/drupal.git/blob/394b9d158f8491dbd4f1c2733d...
Proposed resolution
Translate the placeholders! :-)
Remaining tasks
In #1932652: Add image uploading to WYSIWYGs through editor.module it was discussed whether the placeholder values should uppercase. This needs to be resolved before working on a patch.
Related Issues
- This problem was introduced in #1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms
- #1932652: Add image uploading to WYSIWYGs through editor.module: Where this issue was found and discussed. See comments #52 to #65 over there.
- #421118: [Meta] Standardize capitalization on actions
Comment | File | Size | Author |
---|---|---|---|
#16 | 2067119-translate-image-placeholders-16.patch | 1.86 KB | longwave |
#11 | translate-placeholder-2067119-11.patch | 1005 bytes | pameeela |
Comments
Comment #1
webchickWhile I realize our general standard is to "Capitalize" all strings in the interface, in this case I actually think it would add too much visual emphasis. Not sure. Tagging for the UX team to weigh in on.
Comment #2
Gábor Hojtsy"Needs usability review" would be the right tag I guess.
Comment #3
Wim LeersIssue summary updated to refer to the issue where this was introduced: #1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms.
Comment #4
Wim Leers#1932652: Add image uploading to WYSIWYGs through editor.module landed, now let's get this fixed.
Comment #5
Bojhan CreditAttribution: Bojhan commentedI have no particular preference, how do we lead in general with placeholder text capitalization?
Comment #6
Wim Leers#5 can you rephrase that? I don't understand the usage of the verb "lead" in that phrase.
Comment #7
Bojhan CreditAttribution: Bojhan commentedAs in, what do we commonly use with or without capital?
Comment #8
longwaveThe only core uses of #placeholder at present are:
So we do not have any existing one-word examples other than this and a test module.
I agree with webchick that lowercase seems more aesthetically pleasing and less visually prominent here.
Comment #9
Bojhan CreditAttribution: Bojhan commentedOk, then I think we have a decision, no uppercase.
Comment #10
tstoecklerOK, thanks!
Now we now what to do: Simply add a t() around the existing strings.
Comment #11
pameeela CreditAttribution: pameeela commentedPatch attached, should the field suffix 'pixels' also get translated?
As well should there be another issue to add it to these, based on #8:
Comment #12
pameeela CreditAttribution: pameeela commentedComment #14
Wim Leers#11: translate-placeholder-2067119-11.patch queued for re-testing.
Comment #15
Wim LeersYes, the "pixels" suffix should also be translated.
Thanks so much pameeela for pushing this forward!
(Queued for retesting because it was probably a random failure.)
Comment #16
longwaveLet's translate editor.admin.inc at the same time, as the code is almost identical. This patch adds that and also translates the 'pixels' suffix.
Comment #17
pameeela CreditAttribution: pameeela commentedShould it be $this->t() or does t() suffice? May not make a difference but thought I'd check.
If no difference then this is good for RTBC.
Comment #18
longwaveeditor.admin.inc is a procedural file and $this is not available, so we use plain old t() there.
Comment #19
Wim LeersYay, thanks :)
Comment #20
Wim Leers#16: 2067119-translate-image-placeholders-16.patch queued for re-testing.
Comment #21
webchickCommitted and pushed to 8.x. Thanks!
Comment #22.0
(not verified) CreditAttribution: commentedUpdated issue summary.