[D7] d3.js

I'll look at this now in the Project applications sprint

That situation is a bit unfortunate. I would suggest that you get in contact with that maintainer to talk about collaboration and making you a co-maintainer. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxasherry1477334git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

• Please add title [D7]
• add Git repository path
• what the file .gitignore is for?
• Found sniffer issues in file modules/d3_views/views/plugins/d3_views_plugin_style_d3.inc check http://pareview.sh/pareview/httpgitdrupalorgsandboxasherry1477334git

Updated issue summary.

You already have commit access to the existing d3 project, sou you should push all your commmits to that project.

Then please delete your sandbox, so that there is no confusion anymore which project to use. Then change the git repository and link to project page here in the issue summary, so that we review the correct stuff. Please also correct the issue summary here, you are a co-maintainer now and have access.

@klausi:

We must give @asherry maintainer and node ownership of http://drupal.org/project/d3 as it's very weird @batje was able to create the project. I tried it too and got a validation error.

Even the git log / attribution in @asherry repo should be incorporated. I guess @asherry could use some help with that part.

I contributed to @asherry project so am feeling said about all this :-/

See my #2077711: Can you please rebase this project on the sandbox of asherry including all commit logs.

asherry already has maintainer access on the project, he is just not the project node owner, which is a minor detail and can be fixed with a webmaster issue if everybody agrees.

The git history can be merged, this should do it:

git clone YOURUSER@git.drupal.org:sandbox/asherry/1477334.git d3
cd d3
git remote add fullproject YOURUSER@git.drupal.org:project/d3.git
git fetch fullproject
git merge -s ours fullproject/7.x-1.x
git push fullproject 7.x-1.x

Note that this favors the changes in your sandbox, so in case of conflicts the version from the sandbox is used.

@klausi thanks for the instruction @asherry can use :)

Link to the project page and git clone command are missing in the issue summary, please add them.

I'm a robot and this is an automated message from Project Applications Scraper.

Poor robot, she is trained to detect sandboxes only ;-)

manual review:

1. d3_libraries_info_alter(): why is that needed? Please add a comment.
2. "variable_get('d3_graphapi_default_library', 'forcedirected')": all variables defined by your module need to be removed in hook_uninstall().

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to kscheirer as he might have time to take a final look at this.

I think the module looks great, no major issues found.

Thanks for your contribution, asherry!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.