Remove Unused local variable $display_id from /core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php

Applied the patch and everything seems to be in order.

Having seconds thoughts, looks to me as the patch is removing some functionality. Someone else needs to look at this as well. :)

If this condition in the code is useless then everything would seem fine in my eyes.

-    if ($this->view->display_handler->isDefaulted($plural)) {
-      $display_id = 'default';
-    }

Everything looks fine in the current patch. Just one thing:

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php
@@ -331,7 +327,6 @@ public function usesGroupBy() {
   public function buildGroupByForm(&$form, &$form_state) {

Maybe here we should initiate $group_types to an empty array?

I must've somehow committed this in my last commit spree.

Committed and pushed to 8.x.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php
@@ -108,9 +107,6 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
     if (isset($types[$plural]['plural'])) {
       $plural = $types[$plural]['plural'];
     }
-    if ($this->view->display_handler->isDefaulted($plural)) {

This in fact removes the only usage of $plural, so $plural is now an unnused local variable.

Wrote a new patch because the other patch is already committed in 8.x branch. This patch removes plural definition because it's unused in the init() function.

Committed a34cb25 and pushed to 8.x. Thanks!

Committed as part of a merged commit for #2002650: [meta, no patch] improve maintainability by removing unused local variables