Recoverable fatal error when trying to list badges [#2068009]

I got an unexpected error each time i try to access the badge list.

Error log shows :

Recoverable fatal error : Argument 1 passed to drupal_http_build_query() must be an array, string given, called in /XXX/XXX/www/includes/common.inc on line 2222 and defined dans drupal_http_build_query() (ligne 486 dans /XXX/XXX/www/includes/common.inc).

preceded by three occurences of :

Notice : Undefined variable: account dans theme_user_badge() (ligne 1237 dans /XXX/XXX/www/sites/all/modules/user_badges/user_badges.module).

Line 1237 of the file user_badges.module looks this way :
$href = token_replace($href, array('userbadge' => $badge, 'user' => $account));
full file attached to the issue.

Error occurred just after i added a new badge. I can still access to the tabs image, roles, and settings, though the autocomplete on badges causes HTTP AJAX 500 error, but only if the last badge i added is supposed to appear in the completion (other completions works just fine).

So i guess the problem is linked to the last badge i added. Is there also a way to delete this specific badge manually (without using the badge list which is broken due to this issue) ?

NB: i use drupal 7.23

Comment	File	Size	Author
#8	user_badges-fix_fatal_error_in_drupal_http_build_query-2068009-8.patch	569 bytes	jlandfried
#7	user_badges-fix_fatal_error_in_drupal_http_build_query-2068009-7.patch	523 bytes	jlandfried
#5	user_badges-fix_fatal_error_in_drupal_http_build_query-2068009-5.patch	1.02 KB	shabana.navas
#2	user-badges-screen-shot.png	28.96 KB	shabana.navas
	user_badges.module.txt	44.04 KB	SdG ct

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

SdG ct CreditAttribution: SdG ct commented 18 August 2013 at 17:05

Version:	7.x-1.0	» 7.x-3.x-dev
Status:	Active	» Needs review

I was able to identify the problem source.
It came from the last badge i created which included a link to an external URL in its description, and i solved it by modifying manually the badge entry in the db.
drupaluser_badges_badges, and setting href field to NULL for the concerned badge.

NB : Before doing that, I tried replacing my module version (7.x-1.0) with the 7.x-3.x-dev, which didn't solved the problem, so i assume the 7.x-3.x-dev version is also concerned by the issue and changed the module version of this post accordingly.

Comment #2

shabana.navas CreditAttribution: shabana.navas commented 20 August 2013 at 06:05

File	Size
user-badges-screen-shot.png	28.96 KB

I have tried to replicate this issue by adding a link to the description url, but I am not getting any errors as you have suggested. I have included a screen shot of the badge I tried to add. Let me know if you are doing anything differently.

Comment #3

SdG ct CreditAttribution: SdG ct commented 20 August 2013 at 23:54

Thanks for the answer.
I did upload my own image instead of using and image URL, and the link i used was external (can't see on screenshot if you tested directly on drupal.org or not). apart from that i'm not sure what could have messed things up, i think it has to do with the description link since everything started working again when i removed it into the db. I'll do more testing on my side and try to reproduce the error, I'll keep you informed.

Comment #4

SdG ct CreditAttribution: SdG ct commented 21 August 2013 at 00:05

Found it !

Just use a link containing a GET request :

https://www.google.fr/?q=test

It caused the issue every time.

Comment #5

shabana.navas CreditAttribution: shabana.navas commented 27 August 2013 at 06:33

File	Size
user_badges-fix_fatal_error_in_drupal_http_build_query-2068009-5.patch	1.02 KB

Patch for the 7.x-3.x-dev version is submitted below. Please test it out.

Comment #6

SdG ct CreditAttribution: SdG ct commented 27 August 2013 at 09:49

The patch seems to work perfectly fine for me.
I wasn't sure about the status i should give to this post so i didn't changed it.

Comment #7

jlandfried CreditAttribution: jlandfried commented 28 August 2013 at 17:39

File	Size
user_badges-fix_fatal_error_in_drupal_http_build_query-2068009-7.patch	523 bytes

+    $queries_array = array();
+    foreach($queries as $q) {
+      $query = explode('=', $q);
+      //Add the individual query strings into an associative array
+      $queries_array[$query[0]] = $query[1];
+    }
+    //Now, set $pieces['query'] as an associative array
+    $pieces['query'] = $queries_array;

We can use drupal_get_query_array to do this for us :-)

+    $pieces['query'] = drupal_get_query_array($pieces['query']);

Comment #8

jlandfried CreditAttribution: jlandfried commented 28 August 2013 at 17:54

File	Size
user_badges-fix_fatal_error_in_drupal_http_build_query-2068009-8.patch	569 bytes

Whoops, that last patch threw a notice when the url didn't have query parameters, this one should fix that

Comment #9

shabana.navas CreditAttribution: shabana.navas commented 28 August 2013 at 18:16

Awesome! I knew there was a Drupally way of getting this done. @jiff: Thanks, really appreciate it. Will test it out and if everything works out okay, will commit it to the dev version.