Updated: Comment 0

Problem/Motivation

Now that _title can be added to the route definition we realized that it does not work in connection with forms.
The problem is that it does not use the same code path.

Proposed resolution

For now add the _title to the separate codepath as well.

Remaining tasks

User interface changes

API changes

Files: 
CommentFileSizeAuthor
#13 title-FAIL.patch1.31 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 58,350 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#13 title.patch6.3 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 58,811 pass(es).
[ View ]
#12 title-2068437-12.patch4.8 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 58,633 pass(es).
[ View ]
#10 title-2068437-10.patch2.79 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#8 form_title-2068437-8.patch3.07 KBpwolanin
PASSED: [[SimpleTest]]: [MySQL] 58,531 pass(es).
[ View ]
#8 2068437-5-8.increment.txt1.69 KBpwolanin
#5 form_title-2068437-PASS.patch2.33 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 58,574 pass(es).
[ View ]
#5 form_title-2068437-FAIL.patch1.58 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 58,561 pass(es).
[ View ]
#1 routing-2068437-1.patch765 bytesdawehner
PASSED: [[SimpleTest]]: [MySQL] 57,905 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new765 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,905 pass(es).
[ View ]

.

Issue tags:+WSCCI

.

Status:Needs review» Reviewed & tested by the community

Fixes the problems I had

Status:Reviewed & tested by the community» Needs work

No tests...

Status:Needs work» Needs review
StatusFileSize
new1.58 KB
PASSED: [[SimpleTest]]: [MySQL] 58,561 pass(es).
[ View ]
new2.33 KB
PASSED: [[SimpleTest]]: [MySQL] 58,574 pass(es).
[ View ]

I had added the tag :p

:s srry webchick. I talked about those with dawehner but totally forgot.

Dawehner it's the route one that will fail not the one build with the render array.

Oh, this is maybe just broken on old menu router items? Does your route implement hook_menu and page callback?

StatusFileSize
new1.69 KB
new3.07 KB
PASSED: [[SimpleTest]]: [MySQL] 58,531 pass(es).
[ View ]

per #2032535: Resolve 'title' using the route and render array we shoudl also have _title_callback. Also, the code was in the wrong section of the conditional.

however, parallel work is hapenning on the vire controller yu Crell, so postponing any test addition

Sorry but the title callback is out of scope of this issue, let's do one step after the other.

StatusFileSize
new2.79 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

.

Status:Needs review» Reviewed & tested by the community
Issue tags:+blocker

Looks great and blocks converting things to remove drupal_set_title() from core (and contribs). Eg. I ran into this with #2070055: drupal_set_title() is deprecated. Agreed we don't need to support title callback as core does not do it either.

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new4.8 KB
PASSED: [[SimpleTest]]: [MySQL] 58,633 pass(es).
[ View ]

The problem is that the title issue was not tested with overlay enabled. I think we have to add an explicit test for that.

StatusFileSize
new6.3 KB
PASSED: [[SimpleTest]]: [MySQL] 58,811 pass(es).
[ View ]
new1.31 KB
FAILED: [[SimpleTest]]: [MySQL] 58,350 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Adding a test for overlay to show the failure.

Issue tags:-Needs tests

I think it has tests now. Any others?

Status:Needs review» Reviewed & tested by the community

Thanks for covering overlay. Looks good for me :)

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.