Updated: Comment #0

Problem/Motivation

EntityFormController has a createInstance() method without implementing EntityControllerInterface.

This has led to extreme confusion, since a entity type subclass of this tries to override createInstance(), and it is never called.

Proposed resolution

Either remove the method, or implement the interface.

Remaining tasks

Pick an approach.

User interface changes

N/A

API changes

Either none, or entity forms subclasses no longer need to explicitly implement EntityControllerInterface for injection.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

This was introduced by #2025991: Introduce hook_entity_prepare_form() to generalize hook_node_prepare() for absolutely no reason whatsoever :)

We really should have had a setModuleHandler() instead...

tim.plunkett’s picture

This is obsolete if we go with the new approach in #2059245-22: Add a FormBase class containing useful methods

Xano’s picture

Issue summary: View changes
Status: Needs review » Closed (fixed)

This was apparently fixed somewhere else already.