I am building a site using Flexslider as the main page's slider, via views. The slider was working fine over the last few days, and I was going to delve into tweaking the css for it, when I checked for updates, and I updated it - and updated the db. Now it is kicking off errors.

I have FlexSlider, and FlexSlider Views Style enabled. The error message I am receiving is:

Notice: Undefined index: uri in theme_flexslider_list() (line 48 of /var/www/vhosts/mydomain.com/httpdocs/sites/all/modules/flexslider/theme/flexslider.theme.inc).

Now the slider is not functioning, and I am not sure what the issue is. I deleted the view entirely, and started over. No dice.

I then removed flexslider from the db, and deleted it's files, and started over again...this time the slider works, but the error continues...now it is listed three times...

Any help would be greatly appreciated.

Files: 
CommentFileSizeAuthor
#30 2069435-fields-broken-alpha2.patch13.93 KBminorOffense
Test request sent.
[ View ]
#22 2069435-fix-for-uri-notice.patch1007 bytesjpstrikesback
Test request sent.
Previous result: FAILED: [[SimpleTest]]: [MySQL] 96 pass(es), 44 fail(s), and 0 exception(s).
[ View ]
#16 flex-alpha2.jpg229.22 KBChimos

Comments

Same issue here. Updated to alpha2 and flexslider disappeared.

Here as well, using the flexslider field formatter and the Picture integration. Upon display, these warnings are logged:

Fallback to default optionset.
Warning: Invalid argument supplied for foreach() in template_preprocess_flexslider_picture_list() (line 49 of /home/athomenew/htdocs/sites/all/modules/picture/flexslider_picture/theme/flexslider_picture.theme.inc).

This doesn't seem to affect flex-formatted Views Slideshow displays. Reverting to -alpha1 restored normal operation of the field formatter.

After update to alpha-2 also got uri in theme_flexslider_list(). Slider working but thumbnails as navigation are now missing. I am also using the Picture module.

Component:Views Slideshow Integration» Views Style Plugin

In the mean time I'd suggest continuing to use alpha1.

If you're using an externally integrated module (i.e. Picture) try using FlexSlider without it and see if the error persists. It may be due to the changes to the theme functions that the Picture module integration needs updating.

@dmkeene Did you clear the cache on your site after updating? The theme registry would need to be rebuilt due to some of the changes. Also any views plugin cache would need to be reset as well.

I'll see about that error specifically and see if I can make a smoother upgrade path for alpha3

Also, could you post a copy of your optionset? It'll help me replicate the issue.

Just chiming in: after installing the update, I'm getting the error message:
"Notice: Undefined index: uri in theme_flexslider_list() (line 48 of ...../flexslider/theme/flexslider.theme.inc)."

Successfully reverted to alpha1:
Removed alpha2, replaced with alpha1, cleared caches and ran update.php to get back to proper functioning.

Yes, cleared the cache. Ran Cron, Dumped the tables associated with the module and started from scratch. Upon reinstallation, cleared the cache, etc...

As for option sets - for flexslider or views? Flexslider options are default. View is:

$view = new view();
$view->name = 'front_page_flexslider';
$view->description = '';
$view->tag = 'default';
$view->base_table = 'node';
$view->human_name = 'Front Page Flexslider';
$view->core = 7;
$view->api_version = '3.0';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */
/* Display: Master */
$handler = $view->new_display('default', 'Master', 'default');
$handler->display->display_options['title'] = 'Front Page Flexslider';
$handler->display->display_options['use_more_always'] = FALSE;
$handler->display->display_options['access']['type'] = 'perm';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['pager']['type'] = 'none';
$handler->display->display_options['style_plugin'] = 'flexslider';
$handler->display->display_options['row_plugin'] = 'fields';
$handler->display->display_options['row_options']['inline'] = array(
  'field_image' => 'field_image',
);
$handler->display->display_options['row_options']['hide_empty'] = TRUE;
/* Field: Content: Title */
$handler->display->display_options['fields']['title']['id'] = 'title';
$handler->display->display_options['fields']['title']['table'] = 'node';
$handler->display->display_options['fields']['title']['field'] = 'title';
$handler->display->display_options['fields']['title']['label'] = '';
$handler->display->display_options['fields']['title']['exclude'] = TRUE;
$handler->display->display_options['fields']['title']['alter']['word_boundary'] = FALSE;
$handler->display->display_options['fields']['title']['alter']['ellipsis'] = FALSE;
$handler->display->display_options['fields']['title']['element_label_colon'] = FALSE;
/* Field: Content: Image */
$handler->display->display_options['fields']['field_image']['id'] = 'field_image';
$handler->display->display_options['fields']['field_image']['table'] = 'field_data_field_image';
$handler->display->display_options['fields']['field_image']['field'] = 'field_image';
$handler->display->display_options['fields']['field_image']['label'] = '';
$handler->display->display_options['fields']['field_image']['alter']['trim_whitespace'] = TRUE;
$handler->display->display_options['fields']['field_image']['element_label_colon'] = FALSE;
$handler->display->display_options['fields']['field_image']['element_wrapper_class'] = 'front-page-flex-slider';
$handler->display->display_options['fields']['field_image']['hide_empty'] = TRUE;
$handler->display->display_options['fields']['field_image']['click_sort_column'] = 'fid';
$handler->display->display_options['fields']['field_image']['settings'] = array(
  'image_style' => 'flexslider_full',
  'image_link' => 'content',
);
$handler->display->display_options['fields']['field_image']['delta_offset'] = '0';
/* Sort criterion: Content: Post date */
$handler->display->display_options['sorts']['created']['id'] = 'created';
$handler->display->display_options['sorts']['created']['table'] = 'node';
$handler->display->display_options['sorts']['created']['field'] = 'created';
$handler->display->display_options['sorts']['created']['order'] = 'DESC';
/* Filter criterion: Content: Published */
$handler->display->display_options['filters']['status']['id'] = 'status';
$handler->display->display_options['filters']['status']['table'] = 'node';
$handler->display->display_options['filters']['status']['field'] = 'status';
$handler->display->display_options['filters']['status']['value'] = 1;
$handler->display->display_options['filters']['status']['group'] = 1;
$handler->display->display_options['filters']['status']['expose']['operator'] = FALSE;
/* Filter criterion: Content: Use Content in Slideshow? (field_use_content_in_slideshow_) */
$handler->display->display_options['filters']['field_use_content_in_slideshow__value']['id'] = 'field_use_content_in_slideshow__value';
$handler->display->display_options['filters']['field_use_content_in_slideshow__value']['table'] = 'field_data_field_use_content_in_slideshow_';
$handler->display->display_options['filters']['field_use_content_in_slideshow__value']['field'] = 'field_use_content_in_slideshow__value';
$handler->display->display_options['filters']['field_use_content_in_slideshow__value']['value'] = array(
  1 => '1',
);
/* Display: Block */
$handler = $view->new_display('block', 'Block', 'block');

Went ahead and reverted to alpha1 - all is well...for now.

Although, I am having a time of attempting to get the slide centered on the page. As each slide loads, they offset to the right by about 1-2px. The first is off by about 7px, then it gets worse as each slide loads. Not exactly the place for it, but if you had a quick tip...

Reverted after update as well due to the same error.

I have the same issue on two pages:
http://lafox.de (front page) (see errors)
and http://neofelis.de/referenzen/key-book (Screenshots of my portfolio) (here is the Flex slider hidden)

I cleared cache, executed the cron, updated the tables and resaved the view and Flex slider module settings.

Same issue here. Using Flexslider fields but images do not load after update.

Tried to do a little debugging but I didn't get too far. Seems like the $items variable in the flexslider.tpl.php file is NULL and therefore nothing gets printed. I'm not sure if I am looking in the right place tho.

What is the best way to revert the module back to alpha 1 for those of us that are not sure how to revert a module.

Disable the module (all of it that was checked - 4 parts total).

Delete it from the server (not a Drupal task - I use FTP - some use Git).

Reinstall it from the install path (is a Drupal task).

Enable the module (and any of its parts you need). That's it.

This worked for me. I thank you.

Items being null would be a problem. Probably something in the preprocessor then.

StatusFileSize
new229.22 KB

I'm using default and a custom flexslider configuration, and none of them is showing the slide after updating form alpha1 to alpha2.
I'm using media too as a widget, just updated to 7x-2.0 alpha2 (and some other modules).

The list wrapper is empty in html (attach image)

Went back to alpha1 and its working properly again.

Thanks!

This particular error occurs when there is no URI or link assigned to the slide image. I.e. if you're not linking out your slide anywhere. To suppress the error I just threw this above the $output .= concatenation, just below line 43. Didn't cause anything to fail in my case:

if (! isset($item['uri'])){
        $item['uri'] = "";
}

Then you can do the output concatenation:

$output .= theme('flexslider_list_item', array(
[...]

I got similar issue with the dev version (upgrading 2.0-alpha1+13 to alpha1+17).

I needed some time to get the backups so I started going back in time via the commits page and I got the following results:

1. Latest dev 7.x-2.0-alpha1+17-dev: Slideshow renders OK but gives error messages:
Notice: Undefined index: uri in theme_flexslider_list() (line 48 of /.../modules/flexslider/theme/flexslider.theme.inc).
Notice: Undefined index: uri in theme_flexslider_list() (line 48 of /.../modules/flexslider/theme/flexslider.theme.inc).
Notice: Undefined index: uri in theme_flexslider_list() (line 48 of /.../modules/flexslider/theme/flexslider.theme.inc).

2. Dev version at commit 33dad68: Slideshow renders but damaged and gives the above 3 errors plus one more:
Notice: Trying to get property of non-object in flexslider_views_preprocess_flexslider() (line 45 of /home/.../modules/flexslider/flexslider_views/flexslider_views.module).

3. With version at the commit 8c765a0 and everything works OK.

4. Back to alpha1+17 and the same errors. Back to 8c765a0 all OK.

Another instance that uses the FlexSlider Views Slideshow was not affected.

I reinstalled the Flexslider module like the description above but it works not.

same issue here. After updating to alpha 2 the flexslider doesn't render in views or in a standard flexslider page..
rolled it back..

I upgraded to flexslider 2.0-alpha2 and the slideshows display fine but I was getting the line 48 error mentioned in the summary above. Adding the lines from #17 got rid off the errors for me. There were three listed, one for each slide. But I am using a link field to attach a destination to each slide, and I'm not using a pager.

Status:Active» Needs review
StatusFileSize
new1007 bytes
Test request sent.
Previous result: FAILED: [[SimpleTest]]: [MySQL] 96 pass(es), 44 fail(s), and 0 exception(s).
[ View ]

Here is #17 (essentially). This fixes the notice.

Status:Needs review» Needs work

The last submitted patch, 2069435-fix-for-uri-notice.patch, failed testing.

Line 48 in flexslider.theme.inc :

'thumb' => isset($item['thumb']) ? $item['thumb'] : image_style_url($optionset->imagestyle_thumbnail, $item['uri']),

would be:

'thumb' => isset($item['thumb']) ? $item['thumb'] : image_style_url($optionset->imagestyle_thumbnail, isset($item['uri']) ? $item['uri'] : ''),

I just tried the modification suggested in #24 over 7.x-2.0-alpha1+17-dev and I can confirm that the error messages have gone and the slider works as expected.

#25 modification also worked for me.
thanks dansarmo.

Same happening here with 7.x-2.0-alpha2

Version:7.x-2.0-alpha2» 7.x-2.x-dev
Status:Needs work» Needs review

#22: 2069435-fix-for-uri-notice.patch queued for re-testing.

Title:Updated Flexslider to 2.0-alpha2, now the mainpage slider on my site doesn't work...FlexSlider alpha2 breaks FlexSlider Fields integration
Assigned:Unassigned» minorOffense
StatusFileSize
new13.93 KB
Test request sent.
[ View ]

I've written a patch that fixes the notice and the fields issue. Please test and report back.

@minorOffense so far so good, thank you for the patch.

Please try it with flexslider fields and views on if you could.

Can this patch be applied to the current dev version too? (7.x-2.0-alpha1+17-dev)

It should yes.

Patch above works nicely in views.

trying to apply the patch.. prob my fault some way.. but i get first

sites/all/modules/contrib/flexslider/2069435-fields-broken-alpha2.patch:16: trailing whitespace.
sites/all/modules/contrib/flexslider/2069435-fields-broken-alpha2.patch:22: trailing whitespace.

removed the spaces at those positions in the patch
then tried again.. got fatal: corrupt patch at line 28
turned on the views as noted in #32 and got the same error..
I'll keep at it..

Component:Views Style Plugin» Fields Integration

Trailing whitespace isn't a big deal. Won't affect the code/fix. But I'll make a note to trim it down when I merge it in.

If you want to make your life easier, you can clone the branch where the patch is applied.

https://drupal.org/node/1316346/git-instructions/2069435/nonmaintainer

Hi,

#30 worked for me on a view with a FlexSlider-Format. The view was just showing some collection of articles and their images. What the patch from #30 actually did was make the message "Notice: Undefined index: uri in theme_flexslider_list() (line 48..." disappear.

The view did actually work even before the patch, only the message was confusing. Anyway the patch made it disappear.

Component:Fields Integration» Views Style Plugin

Also a note to #36 and #37:

If I apply the patch with git, I get the "whitespace"-errors:

$ git apply --index ../../patches/flexslider/2069435-fields-broken-alpha2.patch
sites/all/modules/contrib/flexslider/../../patches/flexslider/2069435-fields-broken-alpha2.patch:16: trailing whitespace.
sites/all/modules/contrib/flexslider/../../patches/flexslider/2069435-fields-broken-alpha2.patch:22: trailing whitespace.
warning: 2 lines add whitespace errors.

If I apply it with patch, everything seems to work fine:

$ patch -p1 < ../../patches/flexslider/2069435-fields-broken-alpha2.patch
patching file flexslider.module
patching file flexslider_fields/flexslider_fields.module
patching file flexslider_views/flexslider_views.module
patching file flexslider_views/flexslider_views.views.inc
patching file flexslider_views/flexslider_views_plugin_style_flexslider.inc
patching file flexslider_views/theme/flexslider-views.tpl.php
patching file flexslider_views/theme/flexslider_views.theme.inc
patching file theme/flexslider.theme.inc

After applying the patch flexlider is working again in my views, but not in an image field formatted with flexslider.
I have this problem on a server running php 5.3.x, on a local installation if I use php 5.4.x the same identical site starts to work.

Can you try clearing your caches and updating the config on your fields display? Just go to manage display and resave the settings as required.

I applied the patch (#30) over 7.x-2.0-alpha1+17-dev and I can confirm the module works OK with my setup which involves one slideshow via Views applied as a style and one via views applied as a style plugin to Views Slideshow (which ends in a node page display via EVA). Both work as expected.

I have don't have any fields setup to display via the flexslider formatter.

After applying the patch and clearing all the caches, flexlider still display a notice for a view displayed in 'Block' mode and with the Format:FlexSlider.. no it is OK, I have forgot to patch the good module path !
"root_http/sites/all/modules/flexslider" is not use when there is a "root_http/sites/name_of_the_site/modules/flexslider" (multi-sites)

#30 patch restores the slideshow but still breaks maximenu integration: WARNING: theme hook maximenu_drop not found

#30 worked for me. The slider was always working, but I was getting a ton of error messages in the log which have now stopped. Applied the patch to 7.x-2.0-alpha2.

Has this patch #30 been committed to dev?

Yes it has.

Status:Needs review» Reviewed & tested by the community

After upgrade to lastest dev Version of Flexslider module it shows me no errors anymore on http://lafox.de but the Slider created with Views and pasted in with Panels is now hidden. I resaved the View and Flexslider Settings but without success.

I cleared now the Drupal general cache and receive following error:

Fatal error: Call to undefined function template_preprocess_flexslider_list() in /sites/all/modules/picture/flexslider_picture/theme/flexslider_picture.theme.inc on line 16

It is now assigned with the Picture module for Breakpoints.

#30 works for me too. Thanks a lot.

Minor offense - thank you for your work on this . The latest dev works great

#24 works good. I did not have to downgrade the flexslider alpha version. You just need to change the line #24 mentions and it will no longer prompt the error notice.

Component:Views Style Plugin» Fields Integration
Priority:Normal» Major
Status:Reviewed & tested by the community» Fixed

Fixed in commit 7c0b80f.

Confirmed, thank you very much for solving this quickly !

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Status:Closed (fixed)» Needs review

Hi, I have the same issue reported at #50.

PHP Fatal error: Call to undefined function template_preprocess_flexslider_list() in /srv/www/drupal/sites/all/modules/picture/flexslider_picture/theme/flexslider_picture.theme.inc on line 16

I have no idea how to fix it.

Regards,
Gilsberty

Status:Needs review» Closed (fixed)

Never mind.

My issue is reported here: https://drupal.org/node/2084979

Thanks.

Issue summary:View changes

And updated the db