Hi guys,

While working on writing simpletests for the module (coming soon), I was testing with the Link field module link-7.x-1.0, which is a rather old version, before the problem with the display of the URL path was fixed at:

For any versions of the Link module before these patches were committed, the Image Link Formatter would not display the URL fragment.
Any version from link-7.x-1.1 and above, wouldn't need this code and there shouldn't be any problem with the query or fragment of a URL (because they are already rebuilt in the path before being displayed through the formatter).

I would recommend we try to add a little bit of code to still fix this issue for any versions of the Link field module, before 7.x-1.1.
Additionally, if more changes are made to the Link module in the future, these cases for fragment and query might become useful again.
 

Please let me know if you would have any questions, objections, comments, suggestions, recommendations or concerns on any aspects of this issue, I would be glad to provide more information or explain in more details.

Any questions, feedback, testing, changes, ideas or recommendations would be highly appreciated.
Thanks to all in advance.

Comments

DYdave’s picture

Status: Active » Fixed

Quick follow-up on this issue:

Added a case to test if the URL has a fragment property to be displayed:

<?php
        // Handle fragment if there is any.
        if (!empty($link_values[$delta]['fragment'])) {
          $uri['options']['fragment'] = $link_values[$delta]['fragment'];
        }
?>

 
I went ahead and committed the changes against the 7.x-1.x branch at 2d1ab16.

I allowed myself to mark this issue as fixed for now, but feel free to re-open it, or post a new ticket, at any time if you have any further objections with this issue or related commit 2d1ab16 (we would surely be happy to hear your feedback).

Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on the commit or this ticket in general, I would be glad to provide more information or explain in more details.

Thanks in advance to everyone for your testing, reviews, feedback and comments on this issue.
Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.