Remove image style selection from option set [#2069927]

Since the 2.x version of the FlexSlider library does not depend on an image being present in the slideshow, it no longer makes sense to have the image style settings in the option set.

Instead, it will be assumed that the images are pre-formatted to their desired size (i.e. Field settings, Views settings)

Since this is a rather big change, I'm posting it for comment. I'd like to hear from people (most notably those using the module without FlexSlider Fields or FlexSlider Views since the image size can be controlled there already) how/if this would negatively affect their implementations of FlexSlider.

There are a few issues listed in the queue where thumbnail sizes are being ignore regardless of the image style settings. So I'm hoping that the impact is minimal since it doesn't seem to be working right now anyways.

Comment	File	Size	Author
#4	flexslider-thumbnail-image-styles-2069927-4.patch	1.05 KB	setvik
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

andregriffin CreditAttribution: andregriffin commented 20 August 2013 at 20:30

Yes, I have always used image styes defined elsewhere (Field settings, Views settings). Seems like a reasonable change.

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 23 August 2013 at 13:12

The option to control the thumbnails, if you remain, right?
Me too see correct that option.

Thk!

Comment #3

minorOffense CreditAttribution: minorOffense commented 24 August 2013 at 22:14

Ok I'm going to go ahead with this. The next dev release will have new image style controls for fields.

I'll leave the configured Optionset image style selection in place so people can see/migrate their settings. Perhaps I'll try to write something to migrate the settings automagically.

Comment #4

setvik CreditAttribution: setvik commented 26 September 2013 at 19:18

File	Size
flexslider-thumbnail-image-styles-2069927-4.patch	1.05 KB

Just ran across a possible side-effect of this re: thumbnail image styles.

in template_process_flexslider_list_item(), the thumbnail image, is set to the slide image, which doesn't allow for different image styles to be used for full slides and thumbnails.

Not sure at all what the best fix is because of the image tokens (for security) introduced in Drupal 7.20...

Attached is a bandaid patch (i.e. very much a temporary fix) that applies on 7.x-2.0-alpha3 and sets the thumbnail image style to the style set for thumbnails in the optionset (fields not yet gone from 7.x-2.0-alpha3).