updated as of #14

Should go into the render array now. Also, any hook_menu() item titles can/should go to the routing.yml now: #2032535: Resolve 'title' using the route and render array

Steps to test

  1. install latest d8 and enable config_translation module
  2. go to configuration, site information
  3. pick the translate tab
  4. notice the title

Can also see it on add translation and edit translation.

before:
before-title.png

after (without overlay):
no_overlay.png

after (with overlay):
after-titlenotset.png

after with #2068437-12: _title does not work on _form which fixes overlay
overlay_with_core_form_fix.png

Related Issues

CommentFileSizeAuthor
#14 overlay_with_core_form_fix.png178.61 KBYesCT
#13 no_overlay.png138.42 KBYesCT
#12 config_translation-2070055-9.patch2.31 KBdawehner
#6 title.png8.94 KBdawehner
#6 config_translation-2070055-6.patch1.85 KBdawehner
#4 before-title.png139.47 KBYesCT
#4 after-titlenotset.png141.52 KBYesCT
#1 set-title-gone.patch2.65 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Active » Needs review
FileSize
set-title-gone.patch2.65 KB

Here is a first patch. It does not seem to do its duty at all on my fully updated and freshly installed machine. Any ideas? :/

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

Also see: #2032535-98: Resolve 'title' using the route and render array

YesCT’s picture

YesCT CreditAttribution: YesCT commented

Yeah, I took a look at the change notice, the issue, and was looking for other examples, and got a bit confused.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue summary: View changes

Updated issue summary.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue summary: View changes

added related issues.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
FileSize
after-titlenotset.png141.52 KB
before-title.png139.47 KB

Trying to look into this more, so orienting myself to the task.

so added steps to test to the summary.

I put a before screenshot in the summary.

with the patch
after-titlenotset.png

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue summary: View changes

added steps to test

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue summary: View changes

added before screenshot so people know what kind of page we are talking about.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Yeah the patch is not working well :/

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
config_translation-2070055-6.patch1.85 KB
title.png8.94 KB

Together with a rerolled version of #2068437: _title does not work on _form this patch works for me, see screenshot

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue summary: View changes

retina screen! added width on img

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Postponed

The reroll does not seem to include both drupal_set_title()s AFAIS. #2068437: _title does not work on _form looks like a dependency indeed. It sounds like a problem that drupal_set_title() was depreciated without support to avoid using it... :) Postponing on that one.

Then the patch needs to be updated to include both set titles.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

The reroll does not seem to include both drupal_set_title()s AFAIS. #2068437: _title does not work on _form looks like a dependency indeed. It sounds like a problem that drupal_set_title() was depreciated without support to avoid using it... :) Postponing on that one.

I am sorry that I did not tested all possible codepaths.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Status: Postponed » Needs review

I didn't try it, but looking at it, I dont see #6 changing
drupal_set_title(t('Translations for %label', array('%label' => $group->getTitle())), PASS_THROUGH);

talking in irc...

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Status: Needs review » Postponed

cross posting.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Postponed » Needs review

@dawehner: yeah, no problem :) Funny thing is your screenshot actually shows a drupal_set_title() that you did not change to #title :)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Postponed
FileSize
config_translation-2070055-9.patch2.31 KB

I used the wrong git commit. Thanks YesCT for notifying!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue summary: View changes

added related issue.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
FileSize
no_overlay.png138.42 KB

oh... @dawehner mentioned in irc that the bug of it (#1) not working shows only in overlay.

I checked. and with just #1 and no overlay, I can verify that #1 works and #2068437-10: _title does not work on _form is not a solution:

no_overlay.png

[edit: I messed up with git. see next comment. specified here which patch in 2068437 I was trying.]

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Status: Postponed » Reviewed & tested by the community
FileSize
overlay_with_core_form_fix.png178.61 KB

with #12 (config_translation-2070055-9.patch) here.
and #2068437-12: _title does not work on _form there,

then

it works both in overlay and without.

@Gábor Hojtsy thinks we can commit this here, as 2068437 will take care of the overlay bit.

I also looked at the patch and coding standards and it looks ok and makes sense to me. rtbc.

I can confirm that add and edit config translation titles are also good in overlay and without.

updating issue summary.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue summary: View changes

noting postponed on.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue summary: View changes

updated and clarified overlay fix dependency

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Yay, committed #12. Thanks all!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

#2068437: _title does not work on _form also landed.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

img width