Custom Search working with the Google Appliance module appears to rely on the path 'google-appliance', but this path is not set by the Google Appliance module. From _custom_search_google_appliance_search():

function _custom_search_google_appliance_search($variables) {
  $type = variable_get('google_appliance_default_search_path', 'google-appliance');
  return array('path' => $type . '/' . $variables['keys'], 'query' => array());
}

Google Appliance 7.x uses the path 'gsearch', and doesn't allow you to configure the default search path in the 7.x version.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vinmassaro’s picture

Patch attached to change path to 'gsearch'.

vinmassaro’s picture

Status: Active » Needs review
jdanthinne’s picture

Patch seems ok for me, but if someone else using Google appliance could confirm that, I'd be happy to commit the changes.

vinmassaro’s picture

Appreciate the quick response. You can see Google Appliance sets the search results page to 'gsearch' in google_appliance_menu() and the README states the usage of this path. Thanks.

jdanthinne’s picture

Status: Needs review » Fixed

Ok then, pushed to DEV.

vinmassaro’s picture

Thanks! Would it be possible to get attribution per https://drupal.org/node/1146430?

jdanthinne’s picture

Sorry, I'm using Tower on Mac, and not aware on how to give attribution to a patch…
Do you think it's possible on a patch already committed?

vinmassaro’s picture

Tower will let you revert the commit but not apply the patch with attribution, apparently. You can do both steps easily from the command line. It will revert my commit and then apply the patch using git am:

tmp $ git clone --branch 7.x-1.x http://git.drupal.org/project/custom_search.git
tmp $ cd custom_search
custom_search $ git revert --no-edit c743ab4e501421090482dc200dc5243df7f51d47
[7.x-1.x 3734054] Revert "#2070199: Google Appliance integration relies on 'google-appliance' path but should be 'gsearch' by vinmassaro: change Google appliance search path"
 1 file changed, 1 insertion(+), 1 deletion(-)
custom_search $ git am ~/Downloads/custom_search-google_appliance_path-2070199-2.patch
Applying: change google appliance path to gsearch

You can then load Tower and browse to this clone, and review the work before pushing upstream.

jdanthinne’s picture

vinmassaro’s picture

Much appreciated!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.