Issue #747074: Allow other modules to unset/remove default codecs implements a hook to unset/remove and an UI for it is left for another issue (never created, until now).
This issue is to request a UI for enable/disable a codec.

CommentFileSizeAuthor
#5 video_filter-n2071113-5.patch5.18 KBDamienMcKenna
#3 UI_select_codec-2071113-2.patch4.71 KBmoskito
#1 UI_select_codec-2071113-1.patch2.95 KBmoskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moskito’s picture

moskito CreditAttribution: moskito commented
Status: Active » Needs review
FileSize
UI_select_codec-2071113-1.patch2.95 KB

I create a filter settings that list all available codecs (default codecs are set as enable by default) and a hook 'video_filter_get_codec_enabled($filter)' to list all enabled codecs for a filter.

Chris Burge’s picture

Chris Burge CreditAttribution: Chris Burge commented

This patch tests successfully for me.

It would be useful if the instructions provided by the WYSIWYG plugin were modified to reflect enabled codecs. Instructions for all codecs are still presented to end users regardless of which ones are enabled.

moskito’s picture

moskito CreditAttribution: moskito commented
Issue summary: View changes
Parent issue: » #747074: Allow other modules to unset/remove default codecs
FileSize
UI_select_codec-2071113-2.patch4.71 KB

In this new patch instructions provided by the WYSIWYG plugin are modified to reflect enabled codecs. As codecs are enabled per text format basis, but WYSIWYG plugin don't have text format context, the instruction shows all codecs available to the user (may not available in current text format, but for sure in one that he can use).

Chris Burge’s picture

Chris Burge CreditAttribution: Chris Burge commented

Patch #3 works as described. Thanks for circling back around on this issue. It's too bad that WYSIWYG plugins aren't aware of the active text format. The functionality provided by #3 will probably meet the majority of use cases.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
video_filter-n2071113-5.patch5.18 KB

A minor update that slightly improves the "not all codecs available" disclaimer in the popup, and tightens up the code a little.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: #747074: Allow other modules to unset/remove default codecs » #2297491: Plan for Video Filter v7.x-3.2 release
Related issues: +#747074: Allow other modules to unset/remove default codecs

I was going to set this as RTBC, but then I tweaked the patch. This is good to go, adding it to the proposed issues list for 3.2.

  • DamienMcKenna committed 774d9a5 on 7.x-3.x authored by moskito 
    Issue #2071113 by moskito, DamienMcKenna: Provided UI for controlling...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed. Thanks moskito.

  • DamienMcKenna committed 0884fc3 on 7.x-3.x 
    Issue #2071113 DamienMcKenna: Use internal APIs to list all codecs for...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

FYI I did a follow-up commit to replace the hardcoded list with _video_filter_map_codecs_name(video_filter_get_codec_info()), which is what _video_filter_settings() uses.

minnur’s picture

minnur CreditAttribution: minnur at Chapter Three commented

Moving this up in the queue. From my experience this was confusing. Please make sure you configure your Text filters and enable video filter providers that you need.
When you create new provider you will also need to enable in on the configuration page.

minnur’s picture

minnur CreditAttribution: minnur at Chapter Three commented
Status: Fixed » Closed (fixed)