Allow the settings of htmlmail to use the site default theme.

Again, what are we trying to do here, and why are you changing from NR to NW?

Let's at least try to let the testbot run...

#2 needs a re-roll.

Thank you for the updated patch!

1. +++ b/htmlmail.admin.inc
   @@ -144,11 +144,25 @@ function htmlmail_admin_settings() {
   +  $form['theme']['htmlmail_theme_default'] = array(
   

   This is neither the default theme nor the theme default but (apparently) whether to use the (site's?) default theme.

   I guess the variable should be called something like 'htmlmail_use_default_theme'.

   Why can we not just select that theme if that's what we want?

2. +++ b/htmlmail.admin.inc
   @@ -144,11 +144,25 @@ function htmlmail_admin_settings() {
   +    '#description' => 'Use drupal default theme as defined in appearance as the mail, that will hold your customized templates.',
   

   I'm still confused about what this does. What default are we using for what and what are we overriding?

   (Capital 'D' in 'Drupal')

3. +++ b/htmlmail.admin.inc
   @@ -144,11 +144,25 @@ function htmlmail_admin_settings() {
   +    '#disabled' => $enabled,
   

   You must be kidding...

The purpose of the issue was to let the user select the default theme that is site's default theme as the theme for mail template and not to choose from the dropdown list though yes the user can still choose the theme by just disabling the checkbox. The $enabled variable just updates the state of the dropdown list that should be enabled or not depending on the checkbox value.

Attached a screenshot and patch with some proposed changes.

Ah, now I understand, but I'm sorry, this is over-engineered. All we need for fulfilling this request is an additional option in the drop-down list.

And, D8 has to go first.