Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #2072251: [meta] Modernize forms to use FormBase
Updated: Comment #N
Problem/Motivation
Now that #2059245: Add a FormBase class containing useful methods is in, I was looking at old forms that have empty validateForm() methods, or still use Drupal::service() or t().
Proposed resolution
Convert existing FormInterface forms to extend FormBase
Remaining tasks
User interface changes
API changes
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#5 | aggregator-2072249-5.patch | 30.89 KB | tim.plunkett |
#1 | aggregator-2072249-1.patch | 35.35 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettThe fact that aggregator categories aren't entities is REALLY confusing.
Comment #2
jibranThis is simple swap for
t
to$this->t
so I think it is safe to RTBC.Comment #3
tim.plunkettStandardizing issue names
Comment #4
alexpottPatch no longer applies
Comment #5
tim.plunkett#1957330: Make possible for parsers and fetchers to expose configuration through plugins took care of most of SettingsForm, here's the rest.
Comment #6
webchickCommitted and pushed to 8.x. Thanks!
Comment #7.0
(not verified) CreditAttribution: commentedAdd link to meta issue