Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/views/lib/Drupal/views/Tests/Handler/RelationshipTest.php

Line 128: Unused local variable $key

CommentFileSizeAuthor
#1 core-remove-unused-vars-relationshiptest.php-2072619-1.patch709 byteslegolasbo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented
Assigned: legolasbo » Unassigned
Status: Active » Needs review
FileSize
core-remove-unused-vars-relationshiptest.php-2072619-1.patch709 bytes

Removed unused variable

erik.erskine’s picture

erik.erskine CreditAttribution: erik.erskine commented

Looks fine to me. Applies cleanly.
The $key variable within the foreach block is not necessary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Setting to RTBC according to #2

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed a34cb25 and pushed to 8.x. Thanks!

Committed as part of a merged commit for #2002650: [meta, no patch] improve maintainability by removing unused local variables

Automatically closed -- issue fixed for 2 weeks with no activity.