Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/views/lib/Drupal/views/Tests/Handler/ArgumentNullTest.php

Line 45: Unused local variable $string
Line 71: Unused local variable $string

CommentFileSizeAuthor
#1 core-remove-unused-vars-argumentnulltest.php-2072621-1.patch909 byteslegolasbo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented
Assigned: legolasbo » Unassigned
Status: Active » Needs review
FileSize
core-remove-unused-vars-argumentnulltest.php-2072621-1.patch909 bytes

Removed unused variables

erik.erskine’s picture

erik.erskine CreditAttribution: erik.erskine commented

Looks fine to me - applies ok.
The $string variable doesn't look like it's required.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Setting to RTBC according to #2 and myself.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed a34cb25 and pushed to 8.x. Thanks!

Committed as part of a merged commit for #2002650: [meta, no patch] improve maintainability by removing unused local variables

Automatically closed -- issue fixed for 2 weeks with no activity.