Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/views/lib/Drupal/views/Tests/Handler/FilterDateTest.php

Line 152: Unused local variable $view

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legolasbo’s picture

Assigned: legolasbo » Unassigned
Status: Active » Needs review
FileSize
734 bytes

Removed unused variable

rhm5000’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies, removes unused local variable $view.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/views/lib/Drupal/views/Tests/Handler/FilterDateTest.php
@@ -149,7 +149,7 @@ protected function _testBetween() {
+    views_get_view('test_filter_date_between');

This whole line can be removed - it is unnecessary for the test.

rhm5000’s picture

Status: Needs work » Needs review
FileSize
677 bytes
685 bytes

Patch with whole line removed.

areke’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

The patch applies cleanly; it looks good. Thank you!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.