Follow-up from #2072251: [meta] Modernize forms to use FormBase.

CommentFileSizeAuthor
#7 taxo-forum-2072845-7.patch32.24 KBtim.plunkett
#4 taxo-forum-2072845-4.patch33.14 KBtim.plunkett
#4 interdiff.txt14.57 KBtim.plunkett
#1 taxonomy-2072845-1.patch18.57 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
taxonomy-2072845-1.patch18.57 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

I left the $_GET calls because #1999436: Use Symfony Request for taxonomy module is RTBC.

Status: Needs review » Needs work

The last submitted patch, taxonomy-2072845-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Title: Modernize taxonomy.module forms » Modernize taxonomy.module and forum.module forms
Status: Needs work » Needs review
FileSize
interdiff.txt14.57 KB
taxo-forum-2072845-4.patch33.14 KB

Combining these since forum subclasses taxonomy.

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Needs review » Reviewed & tested by the community

Looks good

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll
FileSize
taxo-forum-2072845-7.patch32.24 KB

Straight reroll.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.