With the style set to "text" and "image and text", the service links are properly contained in an unordered list.

<div class="service-links">
<div class="item-list">
<ul>
<li class="first">
<a class="service-links-reddit" rel="nofollow" title="Submit this post on reddit.com" href="http://reddit.com/submit?url=http%3A//www1/test&title=Test">Reddit</a>
</li>
...
</ul>
</div>
</div>

With the style set to "image", the links are loose in a DIV.
<div class="service-links">
<a class="service-links-reddit" rel="nofollow" title="Submit this post on reddit.com" href="http://reddit.com/submit?url=http%3A//www1/test&title=Test">
<img alt="Reddit logo" src="http://www1/sites/www1/modules/service_links/images/reddit.png" typeof="foaf:Image">
</a>
...
</div>

When using the "non-block" method, configuring the module to use the "only images" style does properly use an unordered list.

Comments

Status:Active» Needs review
StatusFileSize
new611 bytes

Would you prefer something like that?

That definitely fixes the issue I described.

Now that I've got something to compare to, I'm wondering why the source is different between service link blocks and "standard" service links placed with the config page. The "block" version has an extra DIV with the class "item-list", and its UL doesn't have the "links" class. In addition, the "standard" version places the service's class name on both the LI and the A, but the "block" version only places it on the A.

From the "block" version:

<div class="service-links">
<div class="item-list">
<ul>
<li class="first">
<a class="service-links-facebook" rel="nofollow" title="Share via Facebook" href="http://www.facebook.com/sharer.php?u=https%3A//www5/about&t=About">
...

From the "standard" version:

<div class="service-links">
<ul class="links">
<li class="service-links-facebook first">
<a class="service-links-facebook" rel="nofollow" title="Share via Facebook" href="http://www.facebook.com/sharer.php?u=https%3A//www5/about&t=About">
...

Having a quick look yesterday into the theming side of the module, I'm fairly sure it needs some love, unfortunately, neither do I have the time nor do I know the history or reasons why it's like that, so I'm not sure it's my role to do that.
Thanks for your bug report, if you find other related things, that would probably help me tackle whatever needs to be done to have a uniform theming everywhere.

Status:Needs review» Postponed (maintainer needs more info)

Issue summary:View changes

I'm also pretty keen to see this get fixed. Thanks for the patch.

Status:Postponed (maintainer needs more info)» Needs review