When using jQuery update with newer versions of jQuery UI the accordion widget doesn't work if is applied to more than one field. Setting autoHeight: false for jQuery 1.8 and heightStyle: "content" for jQuery 1.9+ fixes it.

CommentFileSizeAuthor
#1 multiple_value_widget.patch411 byteshlykos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hlykos’s picture

hlykos CreditAttribution: hlykos commented
FileSize
multiple_value_widget.patch411 bytes

patch

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Active » Postponed (maintainer needs more info)

Can you provide more information? I've tested it with jQuery 1.8.2 and jQuery UI 1.10.2 . It works for me without the patch.

hlykos’s picture

hlykos CreditAttribution: hlykos commented

if more than one multivalue fields applies the accordion only the first one seems to work. The rest do not toggle to full height, they change their display attribute properly but the height remains 0.

So if there a multivalue image field with accordion on and a multivalue file field with accordion on at the same form only the image field will toggle correctly.

The problem was fixed with the patch. I use jQuery UI 1.8. Haven't tested with jQuery UI 1.9 and 1.10.

Bruno-2M’s picture

Bruno-2M CreditAttribution: Bruno-2M commented
Issue summary: View changes

Fixed the problem for me with JQuery 1.9
Thanks

frob’s picture

frob
Primary language English
CreditAttribution: frob commented
Status: Postponed (maintainer needs more info) » Active

More info was provided.

frob’s picture

frob
Primary language English
CreditAttribution: frob commented
Related issues: +#2084055: Autoheight won't go away with JQuery 1.7 or 1.8, +#2073491: Add autoheight and heightstyle for newer JQuery UI versions
stefanos.petrakis@gmail.com’s picture

stefanos.petrakis@gmail.com
Primary language English
Location Biel, Switzerland
CreditAttribution: stefanos.petrakis@gmail.com as a volunteer commented
Assigned: Unassigned » stefanos.petrakis@gmail.com
Status: Active » Closed (cannot reproduce)
Related issues: -#2073491: Add autoheight and heightstyle for newer JQuery UI versions

Hello everyone,

Just tested this with the following configuration:

  1. Drupal 7.39
  2. jquery_update 7.x-3.0-alpha2 using jQuery 1.5, 1.7, 1.8, 1.9, 1.10
  3. multiple_value_widget (tested with 7.x-1.0-beta3 and 7.x-1.0-beta4)
  4. Article content-type with 3 multiple value fields (Image, Text, Long Text) set to use the Accordion widget

I could not reproduce the reported error (details). The only thing I noticed was that there was too much margin below each field. After applying the patch, this extra margin was gone.

I would like to commit the patch since it improves the rendering, but I need to close this ticket for now.

Cheers,
Stefanos

frob’s picture

frob
Primary language English
CreditAttribution: frob at Clarity Innovations, Inc. commented
Status: Closed (cannot reproduce) » Postponed

I don't understand this.

I would like to commit the patch since it improves the rendering, but I need to close this ticket for now.

If you are planning on doing something about this at a later time then postponed is the correct status.

For a bit more context on this, add an accordion with 100 items some two screens high, and some small (less than a screen high).

frob’s picture

frob
Primary language English
CreditAttribution: frob at Clarity Innovations, Inc. commented
Status: Postponed » Postponed (maintainer needs more info)

As per #8 in another issue.

stefanos.petrakis@gmail.com’s picture

stefanos.petrakis@gmail.com
Primary language English
Location Biel, Switzerland
CreditAttribution: stefanos.petrakis@gmail.com as a volunteer commented

@frob: Thanks for the feedback. Since you gave more information about this, I will have another look. Attaching a screenshot would be great, if you find the time. And agreed, I will leave this as postponed (maintainer needs more info).