Updated: Comment #135
Part ofbeing the 3rd issue in the next sequence:
Developers are not able to add custom operations to an image toolkit. Based on the current design they can only extend a toolkit and implement new operations. For example if they want to add new operations to GD toolkit, they need to extend GD toolkit. Other modules may want to add other operations to the same GD toolkit and they need to extend too GD (but which one?).
Convert image toolkit operations to plugins.
desaturate() will be removed from
ImageToolkitInterface and transformed in plugins.
- Parent: .
- Previous: .
Original report by @fietserwin
The image system has now largely been converted to a plugin based system. As co-maintainer for imagecache_actions this triggered me to start thinking about how to convert our module (that implements a set of image effects) to D8.
The image effects itself will be rather straightforward. but these effects also contain toolkit specific code. Where should I put this code?
Straight forward solution: extend from GDToolkit (and ImageMagickToolkit when available) and put our code in there. Register it as toolkit to use.
However, this has a major problem: if our module extends from GDToolkit and another module that implements image effects does so as well, we have competing toolkits that neither support the full range of image effects.
|PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 68,001 pass(es). |
[ View ]
|FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details.. |
[ View ]