So we aren't replicating the same code on every tour test we should set the seven theme as the admin theme in TourTestBasic.

Files: 
CommentFileSizeAuthor
#9 2073871-9-tourtestbasic-seven-admin-theme.patch3.1 KBnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 58,831 pass(es).
[ View ]
#6 2073871-5-tourtestbasic-seven-admin-theme.interdiff.txt1.02 KBnick_schuch
#6 2073871-5-tourtestbasic-seven-admin-theme.patch4.42 KBnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 58,476 pass(es).
[ View ]
#3 2073871-3-tourtestbasic-seven-admin-theme.interdiff.txt4.39 KBnick_schuch
#3 2073871-3-tourtestbasic-seven-admin-theme.patch4.4 KBnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 58,422 pass(es).
[ View ]
#1 2073871-1-tourtestbasic-seven-admin-theme.patch724 bytesnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 58,560 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new724 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,560 pass(es).
[ View ]

Here we go!

+++ b/core/modules/tour/lib/Drupal/tour/Tests/TourTestBasic.php
@@ -48,6 +48,12 @@
+    \Drupal::config('system.theme')->set('admin', 'seven')->save();

Use $this->container->get('config.factory')->get('system.theme')->set('admin', 'seven')->save() instead

StatusFileSize
new4.4 KB
PASSED: [[SimpleTest]]: [MySQL] 58,422 pass(es).
[ View ]
new4.39 KB

Now with tests™

+++ b/core/modules/tour/tests/tour_test/tour_test.routing.yml
@@ -5,6 +5,13 @@ tour_test_1:
+    _content: '\Drupal\tour_test\Controller\TourTestController::tourTest1'

Should we add the controller just to avoid confusion? Not sure on precedence here.

Other than that, looks ok, I guess the local action could be declared in yml instead of hook_menu() but I'm not sure where thats at yet.

Sorry Drupal\tour_test\Controller\TourTestController::tourTest1 already exists.
As discussed in irc, pwolanin would prefer new local actions use yml instead of hook_menu, makes #2047633: Move definition of menu links to hook_menu_link_defaults(), decouple key name from path, and make 'parent' explicit simpler

StatusFileSize
new4.42 KB
PASSED: [[SimpleTest]]: [MySQL] 58,476 pass(es).
[ View ]
new1.02 KB

As per discussion in IRC. We need to use a yml implementation over hook_menu. Here is the reroll.

Status:Needs review» Reviewed & tested by the community

unless bot disagrees

Status:Reviewed & tested by the community» Needs work
Issue tags:+Needs reroll

Patch no longer applies.

Status:Needs work» Needs review
StatusFileSize
new3.1 KB
PASSED: [[SimpleTest]]: [MySQL] 58,831 pass(es).
[ View ]

Thanks alexpott! Rerolled. Selector change in the TourTest that are not required anymore.

Status:Needs review» Reviewed & tested by the community

back we go

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.