If a tip's body contains list tags, simpletest throws a warning in regards to @attributes.

Files: 
CommentFileSizeAuthor
#4 2073875-tour-list-exceptions-FAIL.patch1.92 KBnick_schuch
FAILED: [[SimpleTest]]: [MySQL] 58,467 pass(es), 0 fail(s), and 4 exception(s).
[ View ]
#4 2073875-tour-list-exceptions-PASS.patch2.74 KBnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 58,440 pass(es).
[ View ]
#1 2073875-1-tourtestbase-modal-tips.patch704 bytesnick_schuch
PASSED: [[SimpleTest]]: [MySQL] 58,561 pass(es).
[ View ]

Comments

Assigned:Unassigned» nick_schuch
Status:Active» Needs review
StatusFileSize
new704 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,561 pass(es).
[ View ]

Here we go!

Status:Needs review» Needs work
Issue tags:+Needs tests

We need a test showing the fail

Title:TourTestBase needs to allows for modal tipsTourTestBase needs to allow for list elements in the body

Actually it's not modal at all. It's list elements in the body of tips. I am endeavouring to write a patch that will expose this.

Status:Needs work» Needs review
StatusFileSize
new2.74 KB
PASSED: [[SimpleTest]]: [MySQL] 58,440 pass(es).
[ View ]
new1.92 KB
FAILED: [[SimpleTest]]: [MySQL] 58,467 pass(es), 0 fail(s), and 4 exception(s).
[ View ]

Here are the patches to both confirm the issue and then fix it.

Status:Needs review» Needs work
Issue tags:-Needs tests

The last submitted patch, 2073875-tour-list-exceptions-PASS.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Needs tests

Status:Needs review» Reviewed & tested by the community
Issue tags:-Needs tests+Quick fix

Good to go, has test coverage and fixes the issue

Status:Reviewed & tested by the community» Fixed

Committed 37ce9e5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

List tags. Not modal.