It will be grate if the Path field in basic edit form for the pane entity (@see fieldable_panels_panes_entity_edit_form) allows more characters. Lets say 2048 which are max characters accepted my the link field module.

CommentFileSizeAuthor
#12 more_characters_in_the_path_field-2074355-12.patch1.3 KBMiroslavBanov
#11 more_characters_in_the_path_field-2074355-11.patch953 bytesMiroslavBanov
#9 more_characters_in_the_path_field-2074355-8.patch951 bytesMiroslavBanov
#7 more_characters_in_the_path_field-2074355-7.patch1.22 KBMiroslavBanov
#6 more_characters_in_the_path_field-2074355-4.patch1.64 KBboyan.borisov
#5 more_characters_in_the_path_field-2074355-3.patch1.64 KBboyan.borisov
#3 more_characters_in_the_path_field-2074355-2.patch1.28 KBboyan.borisov
#1 more_characters_in_the_path_field-2074355-1.patch704 bytesboyan.borisov
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

boyan.borisov’s picture

boyan.borisov CreditAttribution: boyan.borisov commented
Status: Active » Needs review
FileSize
more_characters_in_the_path_field-2074355-1.patch704 bytes

Please find a patch the set a maxlength to 2048 for path field.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Needs work

This won't work unless you also change the table schema for the path field. It's currently a VARCHAR(255) field.

boyan.borisov’s picture

boyan.borisov CreditAttribution: boyan.borisov commented
Status: Needs work » Needs review
FileSize
more_characters_in_the_path_field-2074355-2.patch1.28 KB

sorry, I've missed that. I made a new one that updates the table.

Status: Needs review » Needs work

The last submitted patch, more_characters_in_the_path_field-2074355-2.patch, failed testing.

boyan.borisov’s picture

boyan.borisov CreditAttribution: boyan.borisov commented
Status: Needs work » Needs review
FileSize
more_characters_in_the_path_field-2074355-3.patch1.64 KB

I forgot to merge the two patches at one

boyan.borisov’s picture

boyan.borisov CreditAttribution: boyan.borisov commented
FileSize
more_characters_in_the_path_field-2074355-4.patch1.64 KB

The update hook id was duplicated.

MiroslavBanov’s picture

MiroslavBanov CreditAttribution: MiroslavBanov commented
Issue summary: View changes
FileSize
more_characters_in_the_path_field-2074355-7.patch1.22 KB

Chase head.

Status: Needs review » Needs work

The last submitted patch, 7: more_characters_in_the_path_field-2074355-7.patch, failed testing.

MiroslavBanov’s picture

MiroslavBanov CreditAttribution: MiroslavBanov commented
Status: Needs work » Needs review
FileSize
more_characters_in_the_path_field-2074355-8.patch951 bytes

Chase head again.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Needs work

An update script would be needed to avoid causing problems the next time someone submitted a long link on an existing site.

MiroslavBanov’s picture

MiroslavBanov CreditAttribution: MiroslavBanov commented
FileSize
more_characters_in_the_path_field-2074355-11.patch953 bytes

Chasing head.

MiroslavBanov’s picture

MiroslavBanov CreditAttribution: MiroslavBanov commented
Status: Needs work » Needs review
FileSize
more_characters_in_the_path_field-2074355-12.patch1.3 KB

Here is the same patch with update hook.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Closed (won't fix)

The {menu_router}.path and {url_alias}.path columns are also set to 255 chars, so I'm not going to make this change in case it leads to other problems. That said, feel free to use hook_schema_alter() to make the modification yourself.