In #1986408: Message style update we updated the visual styling of messages to match the #1986434: [meta] New visual style for Seven. We decided the leave the icons to a follow up.

Some Libricons are now in core, instructions of how to add and implement them are in #2032773: Use Libricons (icon font) in Seven, consider using it more broadly in core

Files: 
CommentFileSizeAuthor
#9 2075949-add_libricons_to_messages.patch6.24 KBAdamGerthel
PASSED: [[SimpleTest]]: [MySQL] 58,411 pass(es).
[ View ]
#9 ios retina.png57.99 KBAdamGerthel
#9 svg.png15.99 KBAdamGerthel
#9 png.png15.88 KBAdamGerthel
#6 2075949-add_libricons_to_messages.patch6.37 KBAdamGerthel
PASSED: [[SimpleTest]]: [MySQL] 58,021 pass(es).
[ View ]
#3 2075949-add_libricons_to_messages.patch6.72 KBAdamGerthel
PASSED: [[SimpleTest]]: [MySQL] 58,455 pass(es).
[ View ]
#1 message-icons.zip102.7 KBBojhan

Comments

StatusFileSize
new102.7 KB

Here you go :)

Check, error and warning icons are already included and available in Libricons aren't they?

Nevermind, they're not colored there

Status:Active» Needs review
StatusFileSize
new6.72 KB
PASSED: [[SimpleTest]]: [MySQL] 58,455 pass(es).
[ View ]

Here's a first attempt at adding this. It's my first patch so bare with me.

Hmm, perhaps the old files should be removed as well?

I've searched through core to find any other references to those files and found the following:

message-16-ok.png
- No uses anywhere (after my patch)

message-16-warning.png
- Two uses.

  1. Line 43 in core/modules/dblog/css/dblog.module.css
  2. Line 220 in core/modules/system/css/system.admin.css

message-16-error.png
- Four uses.

  1. Line 49 in core/modules/dblog/css/dblog.module.css
  2. Line 1430 in core/modules/filter/filter.module
  3. Line 87 in core/modules/filter/lib/Drupal/filter/Tests/FilterHtmlImageSecureTest.php
  4. Line 217 in core/modules/system/css/system.admin.css

Status:Needs review» Needs work

Looking good, I think you might want to run the svgs through something like SVGO to remove some of the redundant meta data. Let's remove the icons that are not used and I suppose we'll have to open up a separate issue to replace the icons that are referenced in other files in core.

StatusFileSize
new6.37 KB
PASSED: [[SimpleTest]]: [MySQL] 58,021 pass(es).
[ View ]

Here's a new patch. Metadata removed from the SVG's and deleted message-16-ok.png that isn't used anymore.

Status:Needs work» Needs review

This probably needs some screenshots?

StatusFileSize
new15.88 KB
new15.99 KB
new57.99 KB
new6.24 KB
PASSED: [[SimpleTest]]: [MySQL] 58,411 pass(es).
[ View ]

Fixed SVG sizes (I had made them 32x32 by mistake in my last patch). Screenshots attached.

Status:Needs review» Reviewed & tested by the community

Looks awesome!

Code looks good. RTBC++

Thanks Adam! The icons look so much better.

Committers, please credit Ry5n :)

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Yay :)

Automatically closed -- issue fixed for 2 weeks with no activity.