Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
From field_views_field_default_views_data()
// Override Node to Content.
$group_name = ($entity_info['label'] == t('Node')) ? t('Content') : $entity_info['label'];
Similar code in
file_field_views_data_views_data_alter()
image_field_views_data_views_data_alter()
taxonomy_field_views_data_views_data_alter()
Looks like this comes straight from D7, and is not needed anymore since Node's entity type label is 'Content'...
Comments
Comment #1
yched CreditAttribution: yched commentedTrivial fix, but this is going to conflict with #1497374: Switch from Field-based storage to Entity-based storage, so let's rather get that other one in first :-)
Comment #2
klonos...typo ;)
Comment #3
yched CreditAttribution: yched commentedUn-postponing.
Any takers ? Trivial patch here :-)
Comment #4
lokapujyaComment #5
lokapujyaNo more dancing around this issue.
Comment #6
lokapujyaComment #7
yched CreditAttribution: yched commentedThanks @lokapujya !
You're just missing image_field_views_data_views_data_alter(), otherwise it's good :-)
Comment #8
lokapujyaThanks. Updated.
Comment #9
lokapujyaThanks. Updated.
Comment #11
swentel CreditAttribution: swentel commented#9: unneeded-dance-around-entity-label-2076141-8.patch queued for re-testing.
Comment #12
swentel CreditAttribution: swentel commentedforum.view.inc also contains a 'label' => t('Node'), maybe we should change that to 'Content' in the same run ?
Comment #13
yched CreditAttribution: yched commented@swentel: Hmm, not sure about that one.
The code that gets removed here took care of moving some strings from 'Node' to 'Content', while the actual strings were already 'Content' anyway.
The current code in forum.view.inc specifically uses 'Node' in HEAD. Agreed that it feels wrong, I wouldn't feel fully comfortable changing it here, that feels like a separate issue.
#8 and #9 have the same patch (double post ?), and #8 is green, so RTBC.
Comment #14
lokapujyaYes, it was just an accidental double post.
Comment #15
webchickCommitted and pushed to 8.x. Thanks!
Comment #16
webchickCommitted and pushed to 8.x. Thanks! :D