since i updated field group from 7.1.1 to 7.1.2. it is no more applicable with the crm core entities. All display format with field group of any type(fieldset/horizontal/vertical) is just ignored

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

FreekVR’s picture

Assigned: ChoY » Unassigned
Priority: Normal » Major

I am having a similar issue, fieldgroups created for display modes in the user account don't display *at all*, not even a container/wrapper is being added.

FreekVR’s picture

Status: Active » Needs review
FileSize
721 bytes

I've found out that the user account issue is due to the preprocess function always writing to the 'content' key of the vars array. However, the default user-profile.tpl uses the 'user_profile' key instead. Attached patch fixes this.

Another issue we run into is that we can no longer alter anything related to fieldgroups in our template's preprocess functions. I don't have an idea on how to fix it, since the module uses a theme_registry_alter now to simply add it to the end of the preprocess array. Any thoughts?

FreekVR’s picture

I forgot to unset the original variables in the previous patch, here's a rerolled version.

nils.destoop’s picture

Thx FreekVR, you're patch has been committed.

ChoY, i tried to install the crm core module. But can't seem to get it working. When i add a new contact through ui, i get fatal errors. So i can't check what's wrong with that entity type. Maybe you can check and create a patch?

nils.destoop’s picture

@FreekVR. Change your preprocess functions into process functions. They will run after all the preprocess functions.
We need to alter the theme registry, because we need to make sure all possible preprocess fields are added, before we start grouping.

ChoY’s picture

the field_group bug with crm_core entity display is resolved by this patch: https://drupal.org/node/2075039

arx-e’s picture

I updated today and found lots of my CSS rules were no longer working.
The reason: in filed groups classes the underscores (_) have been replaced with hyphens (-).

Maybe this is related?

ParisLiakos’s picture

same here..my css classes are gone, so no styles work..also i noticed that when there are no associated classes with the fieldgroup the wrapper div does not seem to appear at all

ParisLiakos’s picture

restoring css classes:

/**
 * Implements hook_field_group_pre_render()
 * Fix BC break on css classes.
 */
function HOOK_field_group_pre_render(&$element, $group, &$form) {
  $group->format_settings['instance_settings']['classes'] .= ' ' . $group->group_name;
}

jtalloen’s picture

Same here. Everything was working fine with previous version 7.x-1.1.
After the upgrade groupings were completely gone when displaying user account fields.
Not using any crm modules at all.

nils.destoop’s picture

#10 do you have this problem with latest dev?

For the missing group-group_name css classes. I suggest that people use the solution of #9. The update hook created the class, but with dashes, not with underscores. Using $group->group_name will re-add the underscores.

Status: Needs review » Needs work

The last submitted patch, field_group.user-interface.2077695-3.patch, failed testing.

  • Commit 1086ed3 on 7.x-1.x, 8.x-1.x authored by FreekVR, committed by zuuperman:
    Issue #2077695 by FreekVR | ChoY: Fixed field group entity display bug...
nils.destoop’s picture

Issue summary: View changes
Status: Needs work » Closed (works as designed)