Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of #2072251: [meta] Modernize forms to use FormBase
Updated: Comment #N
Problem/Motivation
Now that #2059245: Add a FormBase class containing useful methods is in, I was looking at old forms that have empty validateForm() methods, or still use Drupal::service() or t().
Proposed resolution
Convert existing FormInterface forms to extend FormBase
Remaining tasks
User interface changes
API changes
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#11 | modernize-responsive_image-module-form-2078001-11.patch | 1.68 KB | JayeshSolanki |
#7 | drupal8.picture-module.2078001-7.patch | 1.51 KB | RoSk0 |
Comments
Comment #1
RainbowArrayIs this something we should check with [attiks] on to get this change started?
Comment #2
RoSk0Initial patch.
Comment #3
plopescIt looks good to me.
However you didn't included in your patch changes that should be made in
PictureMappingFormController
class. Could you work on this class too?Thank you!!
Comment #4
RoSk0Good catch.
New patch.
Comment #5
RoSk0Comment #6
RainbowArrayPatch no longer applies. Needs reroll, then review.
Comment #7
RoSk0Reroll.
Comment #8
RoSk0Sorry for the buzz
Comment #9
Sutharsan CreditAttribution: Sutharsan commentedNeeds reroll tag removed.
Comment #10
attiks CreditAttribution: attiks commentedFYI: picture is renamed to responsive_image so this needs a reroll once #2124377-74: Rename "Picture" module to "Responsive Image" module is committed
Comment #11
JayeshSolanki CreditAttribution: JayeshSolanki commentedRerolled
Comment #12
Eli-TComment #13
JayeshSolanki CreditAttribution: JayeshSolanki commentedComment #14
attiks CreditAttribution: attiks commentedLooks good, thanks
Comment #15
webchickCommitted and pushed to 8.x. Thanks!