Clean-up CommentTestBase [#2078139]

Updated: Comment #0

Problem/Motivation

There's a some type-hinting errors and typos

Proposed resolution

Use proper type-hinting

User interface changes

API changes

Comment	File	Size	Author
#4	interdiff.txt	1.75 KB	andypost
#4	drupal8.comment-module.2078139-4.patch	5.06 KB	andypost
#4
#2	interdiff.txt	846 bytes	andypost
#2	drupal8.comment-module.2078139-2.patch	4.3 KB	andypost
#2
#1	drupal8.comment-module.2078139-1.patch	4.08 KB	andypost
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

andypost

he/him

Russian

CreditAttribution: andypost commented 30 August 2013 at 20:33

Status:

Active

» Needs review

File	Size
drupal8.comment-module.2078139-1.patch	4.08 KB

At least that's enough

Comment #2

andypost

he/him

Russian

CreditAttribution: andypost commented 30 August 2013 at 20:45

File	Size
drupal8.comment-module.2078139-2.patch	4.3 KB

interdiff.txt	846 bytes

And another few places

Comment #3

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 31 August 2013 at 10:13

+++ b/core/modules/comment/lib/Drupal/comment/Tests/CommentTestBase.php
@@ -81,8 +80,8 @@ function setUp() {
+   * @param \Drupal\Core\Entity\EntityInterface|null $node

If we made this $entity here, and removed references to nodes, would that make comment-field tests for other than node easier?

Other than that, looks good to me.

Comment #4

andypost

he/him

Russian

CreditAttribution: andypost commented 31 August 2013 at 20:44

File	Size
drupal8.comment-module.2078139-4.patch	5.06 KB

interdiff.txt	1.75 KB

Done

Comment #5

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 31 August 2013 at 23:10

+++ b/core/modules/comment/lib/Drupal/comment/Tests/CommentTestBase.php
@@ -80,7 +80,7 @@ function setUp() {
    *   Node to post comment on or NULL to post to the previously loaded page.

Still refs node in comments?

Comment #6

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 1 September 2013 at 11:52

Status:

Needs review

» Reviewed & tested by the community

On second thoughts, referencing other than nodes is premature

Comment #7

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 2 September 2013 at 20:53

Status:

Reviewed & tested by the community

» Fixed

Looks good. There are some API changes here, but they only bring this class more in-line with what we do elsewhere, and shouldn't break any existing code.

Committed and pushed to 8.x. Thanks!