When using the Post Date in the comment display it will give you a wsod. Removing the field and everything works again.
Submitted date can be used just not the Post date field.

CommentFileSizeAuthor
#1 2078687-1.patch389 bytesswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swentel’s picture

Status: Active » Needs review
FileSize
389 bytes

Ah, you're right, forgot to update the field definition for that, sorry :/

Could you quickly test following patch ?

erald’s picture

That works.. :) Thanks very much.

swentel’s picture

Version: 7.x-2.5 » 8.x-2.x-dev
Priority: Critical » Normal

Sweet thanks for the quick testing :)

Committed and pushed, will throw out a new release next week or so probably as I have one other annoying bug floating around.

Moving to 8.x-2.x just to verify.

arx-e’s picture

I updated earlier today and most probably I encountered this one.
I reverted quickly to the previous version but I will try to check 2.5 with the patch.

arx-e’s picture

DS updated to 2.5 > errors occur (related to comments) and WSODs > patch applied (+caches cleared) > no errors or WSODs.

arx-e’s picture

But... there is a but!
Which is another issue I discovered to day. At posting new comments I am getting 2 error lines:

Notice: Undefined index: content in ds_render_block_field() (line 923 of /home/xxx/public_html/test/sites/all/modules/ds/ds.module).
Notice: Undefined index: content in ds_render_block_field() (line 945 of /home/xxx/public_html/test/sites/all/modules/ds/ds.module).

The comment is posted all very well - there is just this message.
And when one hits the reply button which takes us to a separate page (a simple not DS managed page), there are no errors at saving the reply comment.

swentel’s picture

arx-e’s picture

The thing is I am working with 7.x-2.5+2-dev + 2077943-7.patch.

Should I replicate my comments to the other post?

swentel’s picture

Sure, although I'm closing reverting the changes I did to ds_render_block_field() to what existed previously. I'd say, follow the issue so you know when that is committed :)

arx-e’s picture

OK, thanks a lot!

swentel’s picture

This is now in the 7.x-2.6 release - see https://drupal.org/node/2081631

arx-e’s picture

OK, updated to 7.x-2.6 and there are no more error messages.

aspilicious’s picture

Status: Needs review » Fixed

Comments are kind broken at the moment in DS 8. But thats a general issue. Improved node post and create date code some more.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.